From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH 1/2] blk-mq: remove the RQF_ELVPRIV check in blk_mq_free_request
Date: Tue, 19 Oct 2021 07:43:04 -0600 [thread overview]
Message-ID: <6393ab57-3a9a-e5ee-6428-c1a4f0bee1f6@kernel.dk> (raw)
In-Reply-To: <20211019133944.2500822-2-hch@lst.de>
On 10/19/21 7:39 AM, Christoph Hellwig wrote:
> If RQF_ELVPRIV is set RQF_ELV is by definition set as well.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> block/blk-mq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index 428e0e0fd5504..34392c439d2a8 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -580,7 +580,7 @@ void blk_mq_free_request(struct request *rq)
> struct request_queue *q = rq->q;
> struct blk_mq_hw_ctx *hctx = rq->mq_hctx;
>
> - if (rq->rq_flags & (RQF_ELVPRIV | RQF_ELV)) {
> + if (rq->rq_flags & RQF_ELV) {
Actually just fixed a bug there. RQF_ELV means "we have an IO
scheduler", and RQF_ELVPRIV means that plus "we have rq private data".
The above shouldn't check RQF_ELV at all, just PRIV.
--
Jens Axboe
next prev parent reply other threads:[~2021-10-19 13:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 13:39 remove RQF_ELVPRIV Christoph Hellwig
2021-10-19 13:39 ` [PATCH 1/2] blk-mq: remove the RQF_ELVPRIV check in blk_mq_free_request Christoph Hellwig
2021-10-19 13:43 ` Jens Axboe [this message]
2021-10-19 13:44 ` Christoph Hellwig
2021-10-19 13:46 ` Jens Axboe
2021-10-19 13:39 ` [PATCH 2/2] blk-mq: remove RQF_ELVPRIV Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6393ab57-3a9a-e5ee-6428-c1a4f0bee1f6@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox