Re: [PATCH 5/5] brd: use memcpy_{to,from]_page in brd_rw_bvec

Hannes Reinecke
2025-04-22T09:30:44Z

On 4/21/25 09:26, Christoph Hellwig wrote:
> Use the proper helpers to copy to/from potential highmem pages, which
> do a local instead of atomic kmap underneath, and perform
> flush_dcache_page where needed. This also simplifies the code so much
> that the separate read write helpers are not required any more.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/block/brd.c | 57 ++++++++++-----------------------------------
> 1 file changed, 12 insertions(+), 45 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich