From: yebin <yebin@huaweicloud.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, ming.lei@redhat.com,
Ye Bin <yebin10@huawei.com>
Subject: Re: [PATCH] block: bio-integrity: fix potential null-ptr-deref in bio_integrity_free
Date: Thu, 6 Jun 2024 19:34:14 +0800 [thread overview]
Message-ID: <66619EB6.4040002@huaweicloud.com> (raw)
In-Reply-To: <ZmFatW3BEzTPgR7S@infradead.org>
On 2024/6/6 14:44, Christoph Hellwig wrote:
> What kernel is this on? As of Linux 6.9 we are now always freezing
v4.18
> the queue while updating the logical_block_size in the nvme driver,
> so there should be no inflight I/O while it is changing.
>
The root cause of the problem is that there is no concurrency protection
between
issuing DIO checks in __ blkdev direct IO simple() and updating logical
block sizes ,
resulting in the block layer being able to see DIOs that are not aligned
with logical
blocks.
next prev parent reply other threads:[~2024-06-06 11:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 6:26 [PATCH] block: bio-integrity: fix potential null-ptr-deref in bio_integrity_free Ye Bin
2024-06-06 6:44 ` Christoph Hellwig
2024-06-06 11:34 ` yebin [this message]
2024-06-06 14:30 ` Ming Lei
2024-06-06 14:52 ` Christoph Hellwig
2024-06-06 15:48 ` Keith Busch
2024-06-06 23:46 ` Ming Lei
2024-06-07 0:13 ` Ming Lei
2024-06-07 1:32 ` yebin
2024-06-07 1:35 ` Ming Lei
2024-06-11 2:48 ` yebin (H)
2024-06-11 3:29 ` Ming Lei
2024-06-17 3:49 ` yebin (H)
2024-06-18 1:43 ` Ming Lei
2024-06-11 9:15 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66619EB6.4040002@huaweicloud.com \
--to=yebin@huaweicloud.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=yebin10@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).