From: "Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>
To: Gaosheng Cui <cuigaosheng1@huawei.com>
Cc: drbd-dev@lists.linbit.com, linux-block@vger.kernel.org,
philipp.reisner@linbit.com, lars.ellenberg@linbit.com,
axboe@kernel.dk
Subject: Re: [PATCH 0/2] Remove orphan declarations for drbd
Date: Wed, 21 Sep 2022 12:33:23 +0200 [thread overview]
Message-ID: <677922df-1674-a872-4bc6-e9c874ee4e46@linbit.com> (raw)
In-Reply-To: <20220920015216.782190-1-cuigaosheng1@huawei.com>
Am 20.09.22 um 03:52 schrieb Gaosheng Cui:
> This series contains a few cleanup patches, to remove a orphan
> declaration which has been removed and some useless comments. Thanks!
>
> Gaosheng Cui (2):
> drbd: remove orphan _req_may_be_done() declaration
> block/drbd: remove useless comments in receive_DataReply()
>
> drivers/block/drbd/drbd_receiver.c | 3 ---
> drivers/block/drbd/drbd_req.h | 2 --
> 2 files changed, 5 deletions(-)
>
Both patches look good to me, thanks.
Acked-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com>
PS: I think trivial fixes like this are important, but they also create
additional maintenance burden. So if you have more of these in the
future, maybe save them up and submit them all at once (maybe even in a
single patch if they are related). Thanks!
--
Christoph Böhmwalder
LINBIT | Keeping the Digital World Running
DRBD HA — Disaster Recovery — Software defined Storage
next prev parent reply other threads:[~2022-09-21 10:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 1:52 [PATCH 0/2] Remove orphan declarations for drbd Gaosheng Cui
2022-09-20 1:52 ` [PATCH 1/2] drbd: remove orphan _req_may_be_done() declaration Gaosheng Cui
2022-09-20 1:52 ` [PATCH 2/2] block/drbd: remove useless comments in receive_DataReply() Gaosheng Cui
2022-09-21 10:33 ` Christoph Böhmwalder [this message]
2022-09-22 1:45 ` [PATCH 0/2] Remove orphan declarations for drbd Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=677922df-1674-a872-4bc6-e9c874ee4e46@linbit.com \
--to=christoph.boehmwalder@linbit.com \
--cc=axboe@kernel.dk \
--cc=cuigaosheng1@huawei.com \
--cc=drbd-dev@lists.linbit.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox