Re: [PATCH blktests v5 1/5] nvme/rc: introduce remote target support

[Chaitanya Kulkarni <chaitanyak@nvidia.com>]

On 12/6/24 05:51, Aurelien Aptel wrote:
> From: Daniel Wagner <dwagner@suse.de>
>
> Most of the NVMEeoF tests are exercising the host code of the nvme
> subsystem. There is no real reason not to run these against an arbitrary
> target. We just have to skip the soft target setup and make it possible
> to setup a remote target.
>
> Because all tests use now the common setup/cleanup helpers we just need
> to intercept this call and forward it to an external component.
>
> As we already have various nvme variables to setup the target which we
> should allow to overwrite. Also introduce a NVME_TARGET_CONTROL variable
> which points to a script which gets executed whenever a targets needs to
> be created/destroyed.
>
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> Signed-off-by: Aurelien Aptel <aaptel@nvidia.com>
> ---
>   


Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck