public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Changheun Lee <nanich.lee@samsung.com>
Cc: axboe@kernel.dk, bgoncalv@redhat.com, hch@lst.de,
	jaegeuk@kernel.org, linux-block@vger.kernel.org,
	ming.lei@redhat.com, yi.zhang@redhat.com
Subject: Re: [PATCH v2] block: Improve limiting the bio size
Date: Mon, 26 Apr 2021 19:46:44 -0700	[thread overview]
Message-ID: <68e4c8f1-1dc6-7dac-289c-5a7595af8d15@acm.org> (raw)
In-Reply-To: <20210427002857.8038-1-nanich.lee@samsung.com>

On 4/26/21 5:28 PM, Changheun Lee wrote:
> __device_add_disk() do not call bio_max_size(). I just imagined bio
> operation on disk without request queue. Disk can be added without queue via
> device_add_disk_no_queue_reg(). It might be my miss-understood about it.
> I didn't check bio operation is possible on disk without request queue yet. 

Inside __device_add_disk() I found the following:

	WARN_ON_ONCE(!blk_get_queue(disk->queue));

I'm not sure how that could work without initializing disk->queue first?

Thanks,

Bart.

  reply	other threads:[~2021-04-27  2:46 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-25  4:30 [PATCH v2] block: Improve limiting the bio size Bart Van Assche
2021-04-25  7:36 ` Yi Zhang
2021-04-25 16:19 ` Jens Axboe
2021-04-26  6:32   ` Yi Zhang
2021-04-26  8:34     ` Changheun Lee
2021-04-26 16:17       ` Bart Van Assche
2021-04-27  0:28         ` Changheun Lee
2021-04-27  2:46           ` Bart Van Assche [this message]
2021-04-27  4:12             ` Changheun Lee
2021-04-27 14:59               ` Bart Van Assche
2021-04-28  7:21                 ` Changheun Lee
2021-04-28 15:52                   ` Bart Van Assche
2021-04-29  6:39                     ` Changheun Lee
2021-05-03  9:28                       ` Changheun Lee
2021-05-03 16:35                         ` Bart Van Assche
2021-04-26 12:54     ` Jens Axboe
2021-04-26 23:43       ` Changheun Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68e4c8f1-1dc6-7dac-289c-5a7595af8d15@acm.org \
    --to=bvanassche@acm.org \
    --cc=axboe@kernel.dk \
    --cc=bgoncalv@redhat.com \
    --cc=hch@lst.de \
    --cc=jaegeuk@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=nanich.lee@samsung.com \
    --cc=yi.zhang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox