From: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
To: Jens Axboe <axboe@kernel.dk>, linux-kernel@vger.kernel.org
Cc: "open list:BLOCK LAYER" <linux-block@vger.kernel.org>
Subject: Re: [PATCH] block/blk-sysfs.c: Remove last reference of blk_init_queue
Date: Tue, 15 Jan 2019 08:29:11 -0200 [thread overview]
Message-ID: <69bddff5-22a1-4ccd-91c3-5dab6c07b1f9@gmail.com> (raw)
In-Reply-To: <d255d497-62aa-9fc3-fa21-20c9b0226a17@kernel.dk>
[-- Attachment #1: Type: text/plain, Size: 680 bytes --]
HI Jeans,
On 1/15/19 1:54 AM, Jens Axboe wrote:
> On 1/14/19 8:06 PM, Marcos Paulo de Souza wrote:
>> blk_init_queue was removed in a1ce35fa4985.
>
> Honestly, most of that comment is wrong anyway. Since this isn't
> a visible API, I'd just kill the comment completely.
I will send a v2 trying to describe better what the function does and
where it is used (or removed it completely as you suggested).
>
>> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
>> ---
>> There are more two references in Documentation/block/biodoc.txt, but maybe that
>> file needs a rewrite in rst anyway?
>
> It probably needs a rewrite - period :-)
>
[-- Attachment #2: pEpkey.asc --]
[-- Type: application/pgp-keys, Size: 1817 bytes --]
prev parent reply other threads:[~2019-01-15 10:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 3:06 [PATCH] block/blk-sysfs.c: Remove last reference of blk_init_queue Marcos Paulo de Souza
2019-01-15 3:54 ` Jens Axboe
2019-01-15 10:29 ` Marcos Paulo de Souza [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69bddff5-22a1-4ccd-91c3-5dab6c07b1f9@gmail.com \
--to=marcos.souza.org@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox