From: Damien Le Moal <dlemoal@kernel.org>
To: Yu Kuai <yukuai1@huaweicloud.com>, Min Li <min15.li@samsung.com>,
hch@lst.de
Cc: axboe@kernel.dk, gregkh@linuxfoundation.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@kernel.org, willy@infradead.org,
"yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH v3] block: add check that partition length needs to be aligned with block size
Date: Thu, 29 Jun 2023 10:15:53 +0900 [thread overview]
Message-ID: <6a9d6824-b1f1-c711-2e24-cac48eefd9e9@kernel.org> (raw)
In-Reply-To: <f8a4e061-22ab-e30b-586b-3a569f5a379a@huaweicloud.com>
On 6/29/23 10:04, Yu Kuai wrote:
> Hi,
>
> 在 2023/06/29 1:07, Min Li 写道:
>> On Mon, Jun 28, 2023 at 04:48:36PM +0000, Christoph Hellwig wrote:
>>> They are long long in the UAPI, which is weird but has been that way
>>> for a long time. So I think we need checks for negative values
>>> before they are shifted and converted to a sector_t.
>>
>> Do you mean that we need to check if p.start and p.length are negative?
>>
>
> Perhaps this patch will make sense.
>
> https://lore.kernel.org/all/20230525072041.3701176-1-zhongjinghua@huawei.com/
+ adding to it the logical block size alignment checks.
>
> Thanks,
> Kuai
>> Thanks for your reply
>>
>> Min li
>> .
>>
>
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2023-06-29 1:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230628051122epcas5p45d70f2c36ce91b60863f702de1534321@epcas5p4.samsung.com>
2023-06-28 13:09 ` [PATCH v3] block: add check that partition length needs to be aligned with block size Min Li
2023-06-28 6:05 ` Damien Le Moal
2023-06-28 7:32 ` Christoph Hellwig
2023-06-28 16:34 ` Min Li
2023-06-28 8:38 ` Christoph Hellwig
2023-06-28 17:07 ` Min Li
2023-06-29 1:04 ` Chaitanya Kulkarni
2023-06-29 1:04 ` Yu Kuai
2023-06-29 1:15 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a9d6824-b1f1-c711-2e24-cac48eefd9e9@kernel.org \
--to=dlemoal@kernel.org \
--cc=axboe@kernel.dk \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=min15.li@samsung.com \
--cc=stable@kernel.org \
--cc=willy@infradead.org \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox