From: Hannes Reinecke <hare@suse.com>
To: Hannes Reinecke <hare@suse.de>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Mike Christie <mchristi@redhat.com>
Subject: Re: [PATCH] block: copy ioprio in __bio_clone_fast()
Date: Mon, 26 Feb 2018 12:40:51 +0100 [thread overview]
Message-ID: <6ad5eabb-30ff-4094-0873-3cb03bba9b1c@suse.com> (raw)
In-Reply-To: <20180226105552.22120-1-hare@suse.de>
On 02/26/2018 11:55 AM, Hannes Reinecke wrote:
> We need to copy the io priority, too; otherwise the clone will run
> with a different priority than the original one.
>
> Fixes: 43b62ce3ff0a ("block: move bio io prio to a new field")
> Signed-off-by: Hannes Reinecke <hare@suse.com>
> ---
> block/bio.c | 1 +
> drivers/vhost/npiv.c | 379 +++++----------------------------------------------
> 2 files changed, 37 insertions(+), 343 deletions(-)
>
> diff --git a/block/bio.c b/block/bio.c
> index e1708db48258..e079911c640f 100644
> --- a/block/bio.c
> +++ b/block/bio.c
> @@ -605,6 +605,7 @@ void __bio_clone_fast(struct bio *bio, struct bio *bio_src)
> bio->bi_write_hint = bio_src->bi_write_hint;
> bio->bi_iter = bio_src->bi_iter;
> bio->bi_io_vec = bio_src->bi_io_vec;
> + bio->bi_ioprio = bio_src->bi_ioprio;
>
> bio_clone_blkcg_association(bio, bio_src);
> }
> diff --git a/drivers/vhost/npiv.c b/drivers/vhost/npiv.c
> index 20e2a66e332d..3527996aab3f 100644
> --- a/drivers/vhost/npiv.c
> +++ b/drivers/vhost/npiv.c
> @@ -13,7 +13,7 @@
Gnaa.
Please ignore.
Will be sending the correct patch.
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.com +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2018-02-26 11:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 10:55 [PATCH] block: copy ioprio in __bio_clone_fast() Hannes Reinecke
2018-02-26 11:40 ` Hannes Reinecke [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-08-01 14:38 Hannes Reinecke
2018-08-01 14:40 ` Johannes Thumshirn
2018-08-01 15:17 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ad5eabb-30ff-4094-0873-3cb03bba9b1c@suse.com \
--to=hare@suse.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=mchristi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox