From: Jens Axboe <axboe@kernel.dk>
To: yangerkun <yangerkun@huawei.com>
Cc: linux-block@vger.kernel.org, ming.lei@redhat.com,
bvanassche@acm.org, hch@lst.de, yi.zhang@huawei.com
Subject: Re: [PATCH v2] blk-mq: call commit_rqs while list empty but error happen
Date: Tue, 29 Sep 2020 08:10:32 -0600 [thread overview]
Message-ID: <6afab9c4-df9c-ad9c-b7a7-9c2e0af64ef6@kernel.dk> (raw)
In-Reply-To: <20200905112556.1735962-1-yangerkun@huawei.com>
On 9/5/20 5:25 AM, yangerkun wrote:
> Blk-mq should call commit_rqs once 'bd.last != true' and no more
> request will come(so virtscsi can kick the virtqueue, e.g.). We already
> do that in 'blk_mq_dispatch_rq_list/blk_mq_try_issue_list_directly' while
> list not empty and 'queued > 0'. However, we can seen the same scene
> once the last request in list call queue_rq and return error like
> BLK_STS_IOERR which will not requeue the request, and lead that list
> empty but need call commit_rqs too(Or the request for virtscsi will stay
> timeout until other request kick virtqueue).
>
> We found this problem by do fsstress test with offline/online virtscsi
> device repeat quickly.
Applied, thanks.--
Jens Axboe
prev parent reply other threads:[~2020-09-29 14:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-05 11:25 [PATCH v2] blk-mq: call commit_rqs while list empty but error happen yangerkun
2020-09-06 2:19 ` Ming Lei
2020-09-29 1:18 ` yangerkun
2020-09-29 14:10 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6afab9c4-df9c-ad9c-b7a7-9c2e0af64ef6@kernel.dk \
--to=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).