From: Wu Bo <wubo40@huawei.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: <josef@toxicpanda.com>, <axboe@kernel.dk>,
<linux-block@vger.kernel.org>, <nbd@other.debian.org>,
<linux-kernel@vger.kernel.org>, <linfeilong@huawei.com>
Subject: Re: [PATCH RESEND] nbd: code clean for nbd_genl_status()
Date: Fri, 5 Nov 2021 09:46:18 +0800 [thread overview]
Message-ID: <6cdbd618-918a-3674-122f-039180ea316b@huawei.com> (raw)
In-Reply-To: <YYOeYwPlLnn7JR+W@infradead.org>
On 2021/11/4 16:48, Christoph Hellwig wrote:
> On Thu, Nov 04, 2021 at 12:38:23PM +0800, Wu Bo wrote:
>> if (!reply_head) {
>> - nlmsg_free(reply);
>> goto out;
>> }
>
> Please also drop the now pointless braces.
>
ok. Will do in v2.
>> out:
>> + if (reply)
>> + nlmsg_free(reply);
>
> Please just use a different label for just unlocking vs also freeing
> the reply.
> .
ok. Will do in v2.
Thanks.
Wu Bo
next prev parent reply other threads:[~2021-11-05 1:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 4:38 [PATCH RESEND] nbd: code clean for nbd_genl_status() Wu Bo
2021-11-04 8:48 ` Christoph Hellwig
2021-11-05 1:46 ` Wu Bo [this message]
2021-11-05 10:01 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cdbd618-918a-3674-122f-039180ea316b@huawei.com \
--to=wubo40@huawei.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=josef@toxicpanda.com \
--cc=linfeilong@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nbd@other.debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox