From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>, Johannes Thumshirn <jthumshirn@suse.de>
Cc: Linux Block Layer Mailinglist <linux-block@vger.kernel.org>,
Hannes Reinecke <hare@suse.de>,
Bart Van Assche <bvanassche@acm.org>, Jan Kara <jack@suse.cz>,
Linux FSDEVEL Mailinglist <linux-fsdevel@vger.kernel.org>,
lkp@01.org, Ming Lei <ming.lei@redhat.com>
Subject: Re: [block] 4e366a7962: blktests.nvme.005.fail
Date: Thu, 28 Mar 2019 11:52:55 -0600 [thread overview]
Message-ID: <6cf48b68-a81b-d28e-96dc-0f8185eddec7@kernel.dk> (raw)
In-Reply-To: <20190328174846.GA22610@lst.de>
On 3/28/19 11:48 AM, Christoph Hellwig wrote:
> On Thu, Mar 28, 2019 at 05:31:29PM +0100, Johannes Thumshirn wrote:
>> In all cases I could reproduce it I had nsegs == 2 and
>> rq->nr_phys_segments == 1 (rq->bio->bi_phys_segments == 1).
>
> And all cases are pass through as well?
>
> Can you check if this still shows up with the series from Ming which
> switches the passthrough requests to use multi-page biovecs aswell
> and gets rid of the hairy code you quote below.
Since I already merged that in my 5.2 but didn't push it out yet, I've
made a temporary branch available if you want to test through that:
git://git.kernel.dk/linux-block 5.2-tmp
--
Jens Axboe
next prev parent reply other threads:[~2019-03-28 17:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190325010409.GB6379@shao2-debian>
2019-03-28 16:31 ` [block] 4e366a7962: blktests.nvme.005.fail Johannes Thumshirn
2019-03-28 17:48 ` Christoph Hellwig
2019-03-28 17:52 ` Jens Axboe [this message]
2019-03-29 8:06 ` Johannes Thumshirn
2019-03-29 0:33 ` Ming Lei
2019-03-29 8:18 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cf48b68-a81b-d28e-96dc-0f8185eddec7@kernel.dk \
--to=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=lkp@01.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox