public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: Lennart Poettering <mzxreary@0pointer.de>, linux-block@vger.kernel.org
Subject: Re: [PATCH 2/2] block: add a partscan sysfs attribute for disks
Date: Thu, 2 May 2024 11:05:54 -0600	[thread overview]
Message-ID: <6e70dd3f-381c-4435-a523-588ce2fafb39@kernel.dk> (raw)
In-Reply-To: <20240502130033.1958492-3-hch@lst.de>

On 5/2/24 7:00 AM, Christoph Hellwig wrote:
> This attribute reports if partition scanning is enabled for a given disk.

This should, at least, have a reference to Lennart's posting, and
honestly a much better commit message as well. There's no reasoning
given here at all.

Maybe even a fixes tag and stable notation?

-- 
Jens Axboe


  reply	other threads:[~2024-05-02 17:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-02 13:00 add a partscan sysfs attribute v2 Christoph Hellwig
2024-05-02 13:00 ` [PATCH 1/2] block: add a disk_has_partscan helper Christoph Hellwig
2024-05-02 13:00 ` [PATCH 2/2] block: add a partscan sysfs attribute for disks Christoph Hellwig
2024-05-02 17:05   ` Jens Axboe [this message]
2024-05-03  8:16     ` Christoph Hellwig
2024-05-03  9:12       ` Keith Busch
2024-05-03 14:59         ` Jens Axboe
2024-05-03 14:57       ` Jens Axboe
2024-05-03 15:01 ` add a partscan sysfs attribute v2 Jens Axboe
  -- strict thread matches above, loose matches on Subject: below --
2024-04-29 17:48 add a partscan sysfs attribute Christoph Hellwig
2024-04-29 17:49 ` [PATCH 2/2] block: add a partscan sysfs attribute for disks Christoph Hellwig
2024-04-30 14:10   ` John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e70dd3f-381c-4435-a523-588ce2fafb39@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=mzxreary@0pointer.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox