Re: [PATCH 2/2] block: add a partscan sysfs attribute for disks

Jens Axboe
2024-05-03T14:59:18Z

On 5/3/24 3:12 AM, Keith Busch wrote:
> On Fri, May 03, 2024 at 10:16:12AM +0200, Christoph Hellwig wrote:
>> On Thu, May 02, 2024 at 11:05:54AM -0600, Jens Axboe wrote:
>>> On 5/2/24 7:00 AM, Christoph Hellwig wrote:
>>>> This attribute reports if partition scanning is enabled for a given disk.
>>>
>>> This should, at least, have a reference to Lennart's posting, and
>>> honestly a much better commit message as well. There's no reasoning
>>> given here at all.
>>
>> I'm not sure I can come up with something much better, feel free to
>> throw in what you prefer.
>
> I think just explaining the "why" would be usesful for the git history.
> How about this:
>
> Userspace had been unknowingly relying on a non-stable interface of
> kernel internals to determine if partition scanning is enabled for a
> given disk. Provide a stable interface for this purpose instead.
>
> Link: https://lore.kernel.org/linux-block/ZhQJf8mzq_wipkBH@gardel-login/

Yep this looks good, I can grab that.

>>> Maybe even a fixes tag and stable notation?
>>
>> This is definitively not a Fixes as nothing it doesn't actually fix
>> any code. It provides a proper interfaces for what was an abuse
>> of leaking internal bits out.
>
> I kind of agree it's not a "Fixes:" in the traditional sense, but at a
> "Cc: <stable>" sounds appropriate given the fallout.

It's definitely not a traditional kind of fixes, even a made-up tag
might be fine for this.

But probably just a Cc: stable@vger.kernel.org # version

and the added link would be good enough.

--
Jens Axboe