Re: [PATCH 2/2] block: add a partscan sysfs attribute for disks

Jens Axboe
2024-05-03T14:57:52Z

On 5/3/24 2:16 AM, Christoph Hellwig wrote:
> On Thu, May 02, 2024 at 11:05:54AM -0600, Jens Axboe wrote:
>> On 5/2/24 7:00 AM, Christoph Hellwig wrote:
>>> This attribute reports if partition scanning is enabled for a given disk.
>>
>> This should, at least, have a reference to Lennart's posting, and
>> honestly a much better commit message as well. There's no reasoning
>> given here at all.
>
> I'm not sure I can come up with something much better, feel free to
> throw in what you prefer.

Really? You have literally nothing in there! It's good practice to
include reasoning for why the change is being done, particularly in this
case where there's quite strong reasonings for the addition.

>> Maybe even a fixes tag and stable notation?
>
> This is definitively not a Fixes as nothing it doesn't actually fix
> any code. It provides a proper interfaces for what was an abuse
> of leaking internal bits out.

I'm looking to bridge the gap between when we yanked the old garbage
interface and now added this one. So yeah it's not a pure fixes, but I
think we should still tie them together somehow so we can do a proper
stable backport of this.

--
Jens Axboe