From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH 3/3] blk-mq: cleanup request allocation
Date: Tue, 23 Nov 2021 09:09:30 -0700 [thread overview]
Message-ID: <6ec32c2f-1f08-b09a-d36a-5da4327026b9@kernel.dk> (raw)
In-Reply-To: <20211123160443.1315598-4-hch@lst.de>
On 11/23/21 9:04 AM, Christoph Hellwig wrote:
> Refactor the request alloction so that blk_mq_get_cached_request tries
> to find a cached request first, and the entirely separate and now
> self contained blk_mq_get_new_requests allocates one or more requests
> if that is not possible.
>
> There is a small change in behavior as submit_bio_checks is called
> twice now if a cached request is present but can't be used, but that
> is a small price to pay for unwinding this code.
I don't think that's an issue, the only side effect that matters here
is the remap which is tracked in the bio anyway.
--
Jens Axboe
next prev parent reply other threads:[~2021-11-23 16:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 16:04 cleanup blk_mq_submit_bio Christoph Hellwig
2021-11-23 16:04 ` [PATCH 1/3] blk-mq: simplify the plug handling in blk_mq_submit_bio Christoph Hellwig
2021-11-23 19:23 ` Jens Axboe
2021-11-23 16:04 ` [PATCH 2/3] blk-mq: move more plug handling from blk_mq_submit_bio into blk_add_rq_to_plug Christoph Hellwig
2021-11-23 16:04 ` [PATCH 3/3] blk-mq: cleanup request allocation Christoph Hellwig
2021-11-23 16:09 ` Jens Axboe [this message]
2021-11-23 16:14 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ec32c2f-1f08-b09a-d36a-5da4327026b9@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox