From: Hannes Reinecke <hare@suse.de>
To: Keith Busch <kbusch@kernel.org>,
Lennart Poettering <mzxreary@0pointer.de>
Cc: Linux regressions mailing list <regressions@lists.linux.dev>,
Christoph Hellwig <hch@lst.de>,
linux-block@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>
Subject: Re: API break, sysfs "capability" file
Date: Tue, 9 Apr 2024 08:09:57 +0200 [thread overview]
Message-ID: <6ef177d7-a565-4ddb-8522-81ffbfb5380e@suse.de> (raw)
In-Reply-To: <ZhRyhDCT5cZCMqYj@kbusch-mbp.dhcp.thefacebook.com>
On 4/9/24 00:41, Keith Busch wrote:
> On Mon, Apr 08, 2024 at 10:23:49PM +0200, Lennart Poettering wrote:
>> Not sure how this is salvageable. This is just seriously fucked
>> up. What now?
>>
>> It has been proposed to use the "range_ext" sysfs attr instead as a
>> hint if partition scanning is available or not. But it's entirely
>> undocumented. Is this something that will remain stable? (I mean,
>> whether something is documented or not apparently has no effect on the
>> stability of an API anyway, so I guess it's equally shaky as the
>> capability sysattr? Is any of the block device sysfs interfaces
>> actually stable or can they change any time?)
>
> The "ext_range" attribute does look like an appropriate proxy for the
> attribute, but indeed, it's not well documented.
>
> Looking at the history of the documentation you had been relying on, it
> appears that was submitted with good intentions (9243c6f3e012a92d), but
> it itself changed values, acknowledging the instability of this
> interface.
>
> So what to do? If documentation is all that's preventing "ext_range"
> from replacing you're previous usage, then let's add it in the
> Documentation/ABI/stable/sysfs-block. It's been there since 2008, so
> that seems like a reliable attribute to put there.
>
I'll side with Keith. Our management tools use 'ext_range' to find
if a device is partitionable, and we've done that since the very
beginning of sysfs.
Cheers,
Hannes
next prev parent reply other threads:[~2024-04-09 6:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 15:13 API break, sysfs "capability" file Lennart Poettering
2024-04-08 17:43 ` Linux regression tracking (Thorsten Leemhuis)
2024-04-08 18:41 ` Keith Busch
2024-04-08 20:23 ` Lennart Poettering
2024-04-08 22:41 ` Keith Busch
2024-04-09 6:09 ` Hannes Reinecke [this message]
2024-04-09 8:19 ` Lennart Poettering
2024-04-09 14:15 ` Christoph Hellwig
2024-04-09 15:17 ` Jens Axboe
2024-04-16 9:26 ` Linux regression tracking (Thorsten Leemhuis)
2024-04-17 15:07 ` Christoph Hellwig
2024-04-16 14:18 ` Lennart Poettering
2024-04-16 14:22 ` Jens Axboe
2024-04-16 14:25 ` Lennart Poettering
2024-04-16 14:33 ` Jens Axboe
2024-04-24 8:09 ` Linux regression tracking (Thorsten Leemhuis)
2024-04-25 13:08 ` Christoph Hellwig
2024-04-16 14:23 ` Lennart Poettering
2024-04-16 14:44 ` Keith Busch
2024-04-17 15:13 ` Christoph Hellwig
2024-04-17 15:48 ` Lennart Poettering
2024-04-17 15:59 ` Christoph Hellwig
2024-04-17 16:10 ` Lennart Poettering
2024-04-17 16:22 ` Christoph Hellwig
2024-04-17 16:26 ` Lennart Poettering
2024-04-17 16:38 ` Christoph Hellwig
2024-04-18 6:28 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ef177d7-a565-4ddb-8522-81ffbfb5380e@suse.de \
--to=hare@suse.de \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mzxreary@0pointer.de \
--cc=regressions@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox