Re: [PATCH v2 9/9] sed-opal: add IOC_OPAL_GET_SUM_STATUS ioctl.

[Milan Broz <gmazyland@gmail.com>]

On 2/5/26 4:09 PM, Ondrej Kozina wrote:
> This adds a function for retrieving the set of Locking objects enabled
> for Single User Mode (SUM) and the value of the
> RangeStartRangeLengthPolicy parameter.
> 
> Signed-off-by: Ondrej Kozina <okozina@redhat.com>

...

> +static int opal_get_sum_ranges(struct opal_dev *dev, struct opal_sum_ranges *opal_sum_rngs,
> +			       void __user *data)
> +{
> +	const struct opal_step admin_steps[] = {
> +		{ start_admin1LSP_opal_session, &opal_sum_rngs->key },
> +		{ get_sum_ranges, opal_sum_rngs },
> +		{ end_opal_session, }
> +	}, anybody_steps[] = {
> +		{ start_anybodyLSP_opal_session, NULL },
> +		{ get_sum_ranges, opal_sum_rngs },
> +		{ end_opal_session, }
> +	};

These two variants need some explanation.

IIRC, TCG doc says that SUM info MAY be available through anybody session.

Of course, some vendors implemented it that is it is not, and you have to use
admin session. So we need both variants, that's ok.

Buy you should document how it works for ioctl params - if admin key is set,
admin session is used, otherwise anybody session is used.

> +	int ret;
> +
> +	mutex_lock(&dev->dev_lock);
> +	setup_opal_dev(dev);
> +	if (opal_sum_rngs->key.key_len)

So, this requires admin password is at least one char, using empty password for
admin is not possible here. It make sense, but it should be documented at least.


> +		ret = execute_steps(dev, admin_steps, ARRAY_SIZE(admin_steps));
> +	else
> +		ret = execute_steps(dev, anybody_steps, ARRAY_SIZE(anybody_steps));
> +	mutex_unlock(&dev->dev_lock);
> +

Otherwise LGTM, even for other patches. If you plan to send v3, I will ack
individual patches.

Thanks,
Milan