From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "hch@lst.de" <hch@lst.de>, "ming.lei@redhat.com" <ming.lei@redhat.com>
Cc: "Williams, Dan J" <dan.j.williams@intel.com>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
"david@fromorbit.com" <david@fromorbit.com>,
"darrick.wong@oracle.com" <darrick.wong@oracle.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: 5.3-rc1 regression with XFS log recovery
Date: Tue, 20 Aug 2019 16:30:56 +0000 [thread overview]
Message-ID: <70d0f825df98351d586285e0629fff16ce345438.camel@intel.com> (raw)
In-Reply-To: <20190820092424.GB21032@ming.t460p>
On Tue, 2019-08-20 at 17:24 +0800, Ming Lei wrote:
>
> It can be quite hard to deal with non-512 aligned sector buffer, since
> one sector buffer may cross two pages, so far one workaround I thought
> of is to not merge such IO buffer into one bvec.
>
> Verma, could you try the following patch?
Hi Ming,
I can hit the same failure with this patch.
Full thread, in case you haven't already seen it:
https://lore.kernel.org/linux-xfs/e49a6a3a244db055995769eb844c281f93e50ab9.camel@intel.com/
>
> diff --git a/block/bio.c b/block/bio.c
> index 24a496f5d2e2..49deab2ac8c4 100644
> --- a/block/bio.c
> +++ b/block/bio.c
> @@ -769,6 +769,9 @@ bool __bio_try_merge_page(struct bio *bio, struct
> page *page,
> if (WARN_ON_ONCE(bio_flagged(bio, BIO_CLONED)))
> return false;
>
> + if (off & 511)
> + return false;
> +
> if (bio->bi_vcnt > 0) {
> struct bio_vec *bv = &bio->bi_io_vec[bio->bi_vcnt - 1];
>
>
> Thanks,
> Ming
next prev parent reply other threads:[~2019-08-20 16:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190818071128.GA17286@lst.de>
[not found] ` <20190818074140.GA18648@lst.de>
[not found] ` <20190818173426.GA32311@lst.de>
[not found] ` <20190819000831.GX6129@dread.disaster.area>
[not found] ` <20190819034948.GA14261@lst.de>
[not found] ` <20190819041132.GA14492@lst.de>
[not found] ` <20190819042259.GZ6129@dread.disaster.area>
[not found] ` <20190819042905.GA15613@lst.de>
[not found] ` <20190819044012.GA15800@lst.de>
[not found] ` <20190820044135.GC1119@dread.disaster.area>
2019-08-20 5:53 ` 5.3-rc1 regression with XFS log recovery hch
2019-08-20 7:44 ` Dave Chinner
2019-08-20 8:13 ` Ming Lei
2019-08-20 9:24 ` Ming Lei
2019-08-20 16:30 ` Verma, Vishal L [this message]
2019-08-20 21:44 ` Dave Chinner
2019-08-20 22:08 ` Verma, Vishal L
2019-08-20 23:53 ` Dave Chinner
2019-08-21 2:19 ` Ming Lei
2019-08-21 1:56 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70d0f825df98351d586285e0629fff16ce345438.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=dan.j.williams@intel.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).