From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF72FC38142 for ; Fri, 27 Jan 2023 07:03:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229964AbjA0HDx (ORCPT ); Fri, 27 Jan 2023 02:03:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229577AbjA0HDx (ORCPT ); Fri, 27 Jan 2023 02:03:53 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E90510DA; Thu, 26 Jan 2023 23:03:51 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B1318200DD; Fri, 27 Jan 2023 07:03:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1674803030; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OzQjW4PPGp55LC9UPKshgKBQV8sYzIFxItt8Fd90xAQ=; b=gITBh/+G94e9A/k75E6f0QgHkdm1iK5jJMqpCtSw4uKOb/eDO+HpCKfKhXf/79C9AQo8E+ NC3CHmThECsbMOlHbHV1ZShUNlC1leMcUt3U0a/93LjcosCvO7n0F13mTpXur/RNLpeZSZ /5uAs0AJzJ1s+LNM/Vn2SVn4yhEj674= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1674803030; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OzQjW4PPGp55LC9UPKshgKBQV8sYzIFxItt8Fd90xAQ=; b=oYxBxAfbtNwan5mN4iER7PdyA/JZDMP6fqCOGmRZbXTe6Tg+Qj29zRwM9kQKaqNOMP6bMD VXdRvG1uiZSpu0Cg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 85CD21336F; Fri, 27 Jan 2023 07:03:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id rtOoH1Z302MQUwAAMHmgww (envelope-from ); Fri, 27 Jan 2023 07:03:50 +0000 Message-ID: <71e9dc41-58d9-eca8-bfec-d9a2e1395c73@suse.de> Date: Fri, 27 Jan 2023 08:03:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH 05/15] blk-cgroup: store a gendisk to throttle in struct task_struct Content-Language: en-US To: Christoph Hellwig , Jens Axboe , Tejun Heo , Josef Bacik Cc: linux-block@vger.kernel.org, cgroups@vger.kernel.org References: <20230117081257.3089859-1-hch@lst.de> <20230117081257.3089859-6-hch@lst.de> From: Hannes Reinecke In-Reply-To: <20230117081257.3089859-6-hch@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 1/17/23 09:12, Christoph Hellwig wrote: > Switch from a request_queue pointer and reference to a gendisk once > for the throttle information in struct task_struct. > > Move the check for the dead disk to the latest place now that is is > unboundled from the reference grab. > > Signed-off-by: Christoph Hellwig > --- > block/blk-cgroup.c | 37 +++++++++++++++++++------------------ > include/linux/sched.h | 2 +- > kernel/fork.c | 2 +- > mm/swapfile.c | 2 +- > 4 files changed, 22 insertions(+), 21 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman