Re: [PATCH 1/2] block: fix zones_cond memory leak in blk_revalidate_disk_zones()

[Damien Le Moal <dlemoal@kernel.org>]

On 3/31/26 18:47, Jackie Liu wrote:
>> This does not look correct: on success case, this will free the array despite
>> that array being set already. So rather than this, I think it is better to
>> change disk_revalidate_zone_resources() to free the array it allocated in the
>> case of an error. That will be a lot cleaner than this.
> 
> Thanks for the review.
> 
> Actually, the free_zones_cond label is only reachable on error paths
> (ret <= 0). On the success path (ret > 0), the function returns
> directly via "return disk_update_zone_resources(disk, &args)" and never
> reaches this label. So the logic should be correct.

Ah, yes, indeed.

> 
> That said, I agree that having disk_revalidate_zone_resources() free
> the array itself on error is cleaner and easier to follow. I'll send
> a v2 with that approach.

Sounds good. Thanks.

> 


-- 
Damien Le Moal
Western Digital Research