RE: [PATCH blktests v1 2/2] nmve/018: Reword misleading error message

Elliott, Robert (Servers)
2020-01-28T19:28:13Z

> -----Original Message-----
> From: linux-block-owner@vger.kernel.org <linux-block-
> owner@vger.kernel.org> On Behalf Of Daniel Wagner
> Sent: Tuesday, January 28, 2020 2:45 AM
> Subject: [PATCH blktests v1 2/2] nmve/018: Reword misleading error message
>
> 'nvme read' is expected to fail, though the error message "ERROR:
> Successfully..." is misleading. Reword the error text to clarify the
> real indent of the test and what failed.

intent

>
> Reported-by: Logan Gunthorpe <logang@deltatee.com>
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
...
> - && echo "ERROR: Successfully read out of device lba range"
> + && echo "ERROR: nvme read was successful for out of range lba"
>

To avoid being picked up by a grep for "success", you could use:
ERROR: nvme read for out of range LBA was not rejected