From: Laurence Oberman <loberman@redhat.com>
To: Christoph Hellwig <hch@lst.de>, Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Ming Lei <ming.lei@redhat.com>,
Jianchao Wang <jianchao.w.wang@oracle.com>,
Hannes Reinecke <hare@suse.com>,
Johannes Thumshirn <jthumshirn@suse.de>,
James Smart <james.smart@broadcom.com>,
Dongli Zhang <dongli.zhang@oracle.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] block: Revert v5.0 blk_mq_request_issue_directly() changes
Date: Fri, 05 Apr 2019 08:43:31 -0400 [thread overview]
Message-ID: <72814f8faee5f55d661863321e48f2a7ef521c63.camel@redhat.com> (raw)
In-Reply-To: <20190405060612.GA32144@lst.de>
On Fri, 2019-04-05 at 08:06 +0200, Christoph Hellwig wrote:
> On Thu, Apr 04, 2019 at 10:08:43AM -0700, Bart Van Assche wrote:
> > blk_mq_try_issue_directly() can return BLK_STS*_RESOURCE for
> > requests that
> > have been queued. If that happens when blk_mq_try_issue_directly()
> > is called
> > by the dm-mpath driver then dm-mpath will try to resubmit a request
> > that is
> > already queued and a kernel crash follows. Since it is nontrivial
> > to fix
> > blk_mq_request_issue_directly(), revert the
> > blk_mq_request_issue_directly()
> > changes that went into kernel v5.0.
>
> And what are we going to do about 5.1+?
Hello Christoph
All the testing of the reverts etc. was agains 5.1-rc3.
I believe the intention is to revert for 5.1x+ and earlier.
Regards
Laurence
next prev parent reply other threads:[~2019-04-05 12:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 17:08 [PATCH] block: Revert v5.0 blk_mq_request_issue_directly() changes Bart Van Assche
2019-04-04 21:43 ` Ming Lei
2019-04-04 22:02 ` Bart Van Assche
2019-04-04 23:49 ` Laurence Oberman
2019-04-05 6:06 ` Christoph Hellwig
2019-04-05 12:43 ` Laurence Oberman [this message]
2019-04-05 13:58 ` Bart Van Assche
2019-04-05 14:00 ` Bart Van Assche
2019-04-05 17:59 ` Jens Axboe
2019-04-09 5:13 ` Stewart Smith
2019-04-09 5:59 ` jianchao.wang
2019-04-17 8:02 ` Stewart Smith
2019-04-09 13:51 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72814f8faee5f55d661863321e48f2a7ef521c63.camel@redhat.com \
--to=loberman@redhat.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=dongli.zhang@oracle.com \
--cc=hare@suse.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=jianchao.w.wang@oracle.com \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).