From: Jens Axboe <axboe@kernel.dk>
To: Kent Overstreet <kent.overstreet@linux.dev>,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org
Cc: Ming Lei <ming.lei@redhat.com>,
Phillip Lougher <phillip@squashfs.org.uk>
Subject: Re: [PATCH 1/3] block: Rework bio_for_each_segment_all()
Date: Wed, 6 Dec 2023 15:40:38 -0700 [thread overview]
Message-ID: <72bf57b0-b5fb-4309-8bfb-63a207a52df7@kernel.dk> (raw)
In-Reply-To: <20231206213424.rn7i42zoyo6zxufk@moria.home.lan>
On 12/6/23 2:34 PM, Kent Overstreet wrote:
> On Wed, Nov 22, 2023 at 06:28:13PM -0500, Kent Overstreet wrote:
>> This patch reworks bio_for_each_segment_all() to be more inline with how
>> the other bio iterators work:
>>
>> - bio_iter_all_peek() now returns a synthesized bio_vec; we don't stash
>> one in the iterator and pass a pointer to it - bad. This way makes it
>> clearer what's a constructed value vs. a reference to something
>> pre-existing, and it also will help with cleaning up and
>> consolidating code with bio_for_each_folio_all().
>>
>> - We now provide bio_for_each_segment_all_continue(), for squashfs:
>> this makes their code clearer.
>
> Jens, can we _please_ get this series merged so bcachefs isn't reaching
> into bio/bvec internals?
Haven't gotten around to review it fully yet, and nobody else has either
fwiw. Would be nice with some reviews.
--
Jens Axboe
next prev parent reply other threads:[~2023-12-06 22:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 23:28 [PATCH 1/3] block: Rework bio_for_each_segment_all() Kent Overstreet
2023-11-22 23:28 ` [PATCH 2/3] block: Rework bio_for_each_folio_all(), add bio_for_each_folio() Kent Overstreet
2023-12-07 19:02 ` Matthew Wilcox
2023-12-07 20:09 ` Matthew Wilcox
2023-12-07 20:45 ` Keith Busch
2023-12-07 22:11 ` Eric Biggers
2023-11-22 23:28 ` [PATCH 3/3] block: Add documentation for bio iterator macros Kent Overstreet
2023-12-07 9:21 ` Ming Lei
2023-12-06 21:34 ` [PATCH 1/3] block: Rework bio_for_each_segment_all() Kent Overstreet
2023-12-06 22:40 ` Jens Axboe [this message]
2023-12-06 23:27 ` Kent Overstreet
2023-12-07 17:57 ` Jens Axboe
2023-12-07 18:06 ` Kent Overstreet
2023-12-07 18:26 ` Jens Axboe
2023-12-07 20:58 ` Matthew Wilcox
2023-12-07 21:01 ` Jens Axboe
2023-12-07 21:04 ` Jens Axboe
2023-12-07 9:20 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72bf57b0-b5fb-4309-8bfb-63a207a52df7@kernel.dk \
--to=axboe@kernel.dk \
--cc=kent.overstreet@linux.dev \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=phillip@squashfs.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox