From: Bart Van Assche <bvanassche@acm.org>
To: John Garry <john.g.garry@oracle.com>, axboe@kernel.dk, hch@lst.de
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH v2 09/12] block: Use enum to define RQF_x bit indexes
Date: Thu, 11 Jul 2024 11:13:06 -0700 [thread overview]
Message-ID: <73bbfc02-eb8c-4553-a7ab-94fd14fb156b@acm.org> (raw)
In-Reply-To: <20240711082339.1155658-10-john.g.garry@oracle.com>
On 7/11/24 1:23 AM, John Garry wrote:
> +enum {
> + /* drive already may have started this one */
> + __RQF_STARTED = 0,
Why " = 0"? I think this is redundant and can be left out.
Additionally, this enum definition would be easier to read if the
comments would start next to "," instead of occurring on a line of
their own.
Thanks,
Bart.
next prev parent reply other threads:[~2024-07-11 18:13 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 8:23 [PATCH v2 00/12] block: Catch missing debugfs flag array members John Garry
2024-07-11 8:23 ` [PATCH v2 01/12] block: remove QUEUE_FLAG_STOPPED John Garry
2024-07-11 8:23 ` [PATCH v2 02/12] block: Make QUEUE_FLAG_x as an enum John Garry
2024-07-11 18:05 ` Bart Van Assche
2024-07-12 10:33 ` John Garry
2024-07-11 8:23 ` [PATCH v2 03/12] block: Add build-time assert for size of blk_queue_flag_name[] John Garry
2024-07-11 8:23 ` [PATCH v2 04/12] block: Catch possible entries missing from hctx_state_name[] John Garry
2024-07-11 18:08 ` Bart Van Assche
2024-07-15 7:54 ` John Garry
2024-07-15 17:28 ` Bart Van Assche
2024-07-15 17:42 ` John Garry
2024-07-11 8:23 ` [PATCH v2 05/12] block: Catch possible entries missing from hctx_flag_name[] John Garry
2024-07-11 18:10 ` Bart Van Assche
2024-07-15 7:55 ` John Garry
2024-07-11 8:23 ` [PATCH v2 06/12] block: Catch possible entries missing from alloc_policy_name[] John Garry
2024-07-11 18:16 ` Bart Van Assche
2024-07-11 8:23 ` [PATCH v2 07/12] block: Add missing entries from cmd_flag_name[] John Garry
2024-07-11 18:16 ` Bart Van Assche
2024-07-11 8:23 ` [PATCH v2 08/12] block: Catch possible entries missing " John Garry
2024-07-11 18:15 ` Bart Van Assche
2024-07-11 8:23 ` [PATCH v2 09/12] block: Use enum to define RQF_x bit indexes John Garry
2024-07-11 18:13 ` Bart Van Assche [this message]
2024-07-15 7:58 ` John Garry
2024-07-11 8:23 ` [PATCH v2 10/12] block: Simplify definition of RQF_NAME() John Garry
2024-07-11 18:14 ` Bart Van Assche
2024-07-11 8:23 ` [PATCH v2 11/12] block: Add zone write plugging entry to rqf_name[] John Garry
2024-07-11 18:14 ` Bart Van Assche
2024-07-11 8:23 ` [PATCH v2 12/12] block: Catch possible entries missing from rqf_name[] John Garry
2024-07-11 18:15 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73bbfc02-eb8c-4553-a7ab-94fd14fb156b@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=john.g.garry@oracle.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).