public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Yu Kuai <yukuai1@huaweicloud.com>
To: Tejun Heo <tj@kernel.org>, Yu Kuai <yukuai1@huaweicloud.com>
Cc: axboe@kernel.dk, ming.lei@redhat.com, mkoutny@suse.com,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	cgroups@vger.kernel.org, yi.zhang@huawei.com,
	"yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH v8 1/4] blk-throttle: fix that io throttle can only work for single bio
Date: Wed, 24 Aug 2022 09:15:32 +0800	[thread overview]
Message-ID: <73c72914-e27d-b261-e040-2dd31e8a6b9f@huaweicloud.com> (raw)
In-Reply-To: <YwUXTL+8E/sPcEUB@slm.duckdns.org>

Hi, Tejun

在 2022/08/24 2:07, Tejun Heo 写道:
> Hello,
> 
> Should have asked you earlier but with the BIO_THROTTLED flag setting from
> clone removed, with single BIO_THROTTLED flag, does the fix still require
> bytes subtraction? If we can do single flag and we don't need the bytes
> subtraction, might as well just stay with single flag?

Do you mean 'compensate the over-accounting' for bytes subtraction? If
so, yes, it's not required.

This patch actually set two flags when bio is throttled and
dispatched, and only iops flag is cleared after the original bio is
split. If only one flag can be used, the way that I come up with is
that let iops limit become default, which means bio is always counted
for iops limit each time blk_throtl_bio() is called. I'm not quite
sure yet if iops limit can be counted excessively this way in some
special scenario...

Thanks,
Kuai
> 
> Thanks.
> 


  reply	other threads:[~2022-08-24  1:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-23  3:31 [PATCH v8 0/4] blk-throttle bugfix Yu Kuai
2022-08-23  3:31 ` [PATCH v8 1/4] blk-throttle: fix that io throttle can only work for single bio Yu Kuai
2022-08-23 18:07   ` Tejun Heo
2022-08-24  1:15     ` Yu Kuai [this message]
2022-08-25 18:15       ` Tejun Heo
2022-08-26  1:07         ` Yu Kuai
2022-08-23  3:31 ` [PATCH v8 2/4] blk-throttle: prevent overflow while calculating wait time Yu Kuai
2022-08-23  3:31 ` [PATCH v8 3/4] blk-throttle: factor out code to calculate ios/bytes_allowed Yu Kuai
2022-08-23  3:31 ` [PATCH v8 4/4] blk-throttle: fix io hung due to configuration updates Yu Kuai
2022-08-23  9:41   ` Michal Koutný
2022-08-23 18:08   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73c72914-e27d-b261-e040-2dd31e8a6b9f@huaweicloud.com \
    --to=yukuai1@huaweicloud.com \
    --cc=axboe@kernel.dk \
    --cc=cgroups@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=mkoutny@suse.com \
    --cc=tj@kernel.org \
    --cc=yi.zhang@huawei.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox