From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>, Max Gurtovoy <maxg@mellanox.com>
Cc: linux-block@vger.kernel.org, martin.petersen@oracle.com,
linux-nvme@lists.infradead.org, keith.busch@intel.com,
sagi@grimberg.me, shlomin@mellanox.com, israelr@mellanox.com
Subject: Re: [PATCH v6 1/2] block: use symbolic constants for t10_pi type
Date: Mon, 16 Sep 2019 08:57:18 -0600 [thread overview]
Message-ID: <7465169a-dc9d-ae72-99bd-204e7402c279@kernel.dk> (raw)
In-Reply-To: <20190916075151.GA25796@lst.de>
On 9/16/19 1:51 AM, Christoph Hellwig wrote:
> On Sat, Sep 14, 2019 at 11:34:12PM +0300, Max Gurtovoy wrote:
>> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
>> Signed-off-by: Max Gurtovoy <maxg@mellanox.com>
>
> A little bit of a changelog would have been nice, but otherwise this
> looks fine to me:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Yeah, please always include a commit message. There's always some
possible explanation, even if you think the title covers it.
--
Jens Axboe
prev parent reply other threads:[~2019-09-16 14:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-14 20:34 [PATCH v6 1/2] block: use symbolic constants for t10_pi type Max Gurtovoy
2019-09-14 20:34 ` [PATCH 2/2] block: centralize PI remapping logic to the block layer Max Gurtovoy
2019-09-16 7:59 ` Christoph Hellwig
2019-09-16 7:51 ` [PATCH v6 1/2] block: use symbolic constants for t10_pi type Christoph Hellwig
2019-09-16 14:57 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7465169a-dc9d-ae72-99bd-204e7402c279@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=israelr@mellanox.com \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=maxg@mellanox.com \
--cc=sagi@grimberg.me \
--cc=shlomin@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).