linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org
Subject: Re: [PATCH 0/3] Fix a deadlock related to modifying queue attributes
Date: Thu, 10 Jul 2025 12:29:37 -0700	[thread overview]
Message-ID: <750d4fbd-b3f4-40b6-b07e-f0c47fef6dba@acm.org> (raw)
In-Reply-To: <20250710080341.GA8622@lst.de>

On 7/10/25 1:03 AM, Christoph Hellwig wrote:
> On Tue, Jul 08, 2025 at 09:11:41AM -0700, Bart Van Assche wrote:
>> * Slower booting of Linux devices that modify sysfs attributes
>>    synchronously during boot.
> 
> So which attributes are regularly modified?  Note that for read-ahead
> it should be safe to drop the freeze as unlike the others it is not
> used for splitting I/O to the limits accepted by the hardware.  So
> we could probably drop the freeze IFF the patch documents that it is
> safe.  But it still won't fix the root cause.

I can't answer the above question for all Linux distros. But I can
answer this question for Android. Here is what I found in the AOSP
platform code, which includes startup (.rc) scripts for all Android
vendors:

$ repo-grep -nHE 'write (/sys/block|/sys/class/block)' '**rc' | \
     sed 's,.*/,,;s/ .*//' | sort | uniq -c | sort -rn | head -n5
      46 read_ahead_kb      # Implemented in block/blk-sysfs.c
      27 scheduler          # Implemented in block/blk-sysfs.c
      20 slice_idle         # BFQ I/O scheduler
      17 comp_algorithm     # zram kernel driver
       4 discard_max_bytes  # Implemented in block/blk-sysfs.c

Thanks,

Bart.


  reply	other threads:[~2025-07-10 19:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-02 18:24 [PATCH 0/3] Fix a deadlock related to modifying queue attributes Bart Van Assche
2025-07-02 18:24 ` [PATCH 1/3] block: Remove queue freezing from several sysfs store callbacks Bart Van Assche
2025-07-03  2:08   ` Ming Lei
2025-07-03  9:06     ` Christoph Hellwig
2025-07-02 18:24 ` [PATCH 2/3] block: Restrict the duration of sysfs attribute changes Bart Van Assche
2025-07-03  9:07   ` Christoph Hellwig
2025-07-03 14:54   ` Nilay Shroff
2025-07-02 18:24 ` [PATCH 3/3] block: Move a misplaced comment in queue_wb_lat_store() Bart Van Assche
2025-07-03  9:09 ` [PATCH 0/3] Fix a deadlock related to modifying queue attributes Christoph Hellwig
2025-07-07 18:35   ` Bart Van Assche
2025-07-08  9:57     ` Christoph Hellwig
2025-07-08 16:11       ` Bart Van Assche
2025-07-10  8:03         ` Christoph Hellwig
2025-07-10 19:29           ` Bart Van Assche [this message]
2025-07-08 17:16       ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=750d4fbd-b3f4-40b6-b07e-f0c47fef6dba@acm.org \
    --to=bvanassche@acm.org \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).