From: Coly Li <colyli@suse.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-bcache@vger.kernel.org
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH] lib/crc64.c: add MODULE_LICENSE("GPL")
Date: Tue, 22 May 2018 16:47:33 +0800 [thread overview]
Message-ID: <7525b76a-8e13-b68f-0ae0-427bc6cb72fa@suse.de> (raw)
In-Reply-To: <6e9bdb5464689cc3ade4c09683e38f9f0104948b.camel@linux.intel.com>
On 2018/5/22 4:43 PM, Andy Shevchenko wrote:
> On Tue, 2018-05-22 at 16:40 +0800, Coly Li wrote:
>> This patch adds MODULE_LICENSE("GPL") to lib/crc64.c to remove a
>> compiling
>> warninng.
>
> I have no opinion about this. Code has a top description from which it
> has been taken / derived, so, I dunno if GPL is what it really is.
>
> In any case it's probably worth to add SPDX header as well.
>
Hmm, there is a warning complains no MODULE_LICENSE() in lib/crc64.c,
when I compile a kernel for testing. The purpose is just to kill a
compiler warning.
And sure, I will post an update version with SPDX header.
Thanks for the hint :-)
Coly Li
>>
>> Signed-off-by: Coly Li <colyli@suse.de>
>> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> ---
>> lib/crc64.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/lib/crc64.c b/lib/crc64.c
>> index ed0ffac7b26a..586e46684ee8 100644
>> --- a/lib/crc64.c
>> +++ b/lib/crc64.c
>> @@ -135,3 +135,4 @@ uint64_t crc64(const void *data, size_t len)
>> EXPORT_SYMBOL_GPL(crc64);
>>
>> MODULE_DESCRIPTION("CRC64 calculations");
>> +MODULE_LICENSE("GPL");
>
prev parent reply other threads:[~2018-05-22 8:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 8:40 [PATCH] lib/crc64.c: add MODULE_LICENSE("GPL") Coly Li
2018-05-22 8:43 ` Andy Shevchenko
2018-05-22 8:47 ` Coly Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7525b76a-8e13-b68f-0ae0-427bc6cb72fa@suse.de \
--to=colyli@suse.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox