From: Jens Axboe <axboe@kernel.dk>
To: Chaitanya Kulkarni <kch@nvidia.com>, linux-block@vger.kernel.org
Cc: Himanshu Madhani <himanshu.madhani@oracle.com>
Subject: Re: [PATCH V2 4/4] loop: allow user to set the queue depth
Date: Tue, 15 Feb 2022 07:54:03 -0700 [thread overview]
Message-ID: <75d43e3b-e13e-f78c-b120-cb3de5ff0e63@kernel.dk> (raw)
In-Reply-To: <20220215115104.11429-5-kch@nvidia.com>
On 2/15/22 4:51 AM, Chaitanya Kulkarni wrote:
> Instead of hardcoding queue depth allow user to set the hw queue depth
> using module parameter. Set default value to 128 to retain the existing
> behavior.
Do we want to ensure that the depth falls within a reasonable range? I
guess we don't if we just ensure that it fails gracefully. Eg have you
tried the usual sanity checks of -1, 0, 1, huge?
--
Jens Axboe
next prev parent reply other threads:[~2022-02-15 14:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 11:51 [PATCH V2 0/4] loop: cleanup and few improvements Chaitanya Kulkarni
2022-02-15 11:51 ` [PATCH V2 1/4] loop: use sysfs_emit() in the sysfs xxx show() Chaitanya Kulkarni
2022-02-15 11:51 ` [PATCH V2 2/4] loop: remove extra variable in lo_fallocate() Chaitanya Kulkarni
2022-02-15 11:51 ` [PATCH V2 3/4] loop: remove extra variable in lo_req_flush Chaitanya Kulkarni
2022-02-15 11:51 ` [PATCH V2 4/4] loop: allow user to set the queue depth Chaitanya Kulkarni
2022-02-15 14:54 ` Jens Axboe [this message]
2022-02-15 16:54 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75d43e3b-e13e-f78c-b120-cb3de5ff0e63@kernel.dk \
--to=axboe@kernel.dk \
--cc=himanshu.madhani@oracle.com \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox