From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAC32ECAAA1 for ; Wed, 31 Aug 2022 00:45:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231656AbiHaApu (ORCPT ); Tue, 30 Aug 2022 20:45:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231747AbiHaApW (ORCPT ); Tue, 30 Aug 2022 20:45:22 -0400 Received: from out30-132.freemail.mail.aliyun.com (out30-132.freemail.mail.aliyun.com [115.124.30.132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A55DEB14ED; Tue, 30 Aug 2022 17:43:32 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R501e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046056;MF=liusong@linux.alibaba.com;NM=1;PH=DS;RN=3;SR=0;TI=SMTPD_---0VNoHCXB_1661906562; Received: from 30.227.181.248(mailfrom:liusong@linux.alibaba.com fp:SMTPD_---0VNoHCXB_1661906562) by smtp.aliyun-inc.com; Wed, 31 Aug 2022 08:42:43 +0800 Message-ID: <75f53b8f-30cd-23c3-1602-34d858302751@linux.alibaba.com> Date: Wed, 31 Aug 2022 08:42:42 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.0.3 Subject: Re: [RFC PATCH] blk-mq: change bio_set_ioprio to inline To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <1661852746-117244-1-git-send-email-liusong@linux.alibaba.com> <908d464e-e695-3a27-56f6-1ceabd727989@kernel.dk> From: Liu Song In-Reply-To: <908d464e-e695-3a27-56f6-1ceabd727989@kernel.dk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 2022/8/30 21:59, Jens Axboe wrote: > On 8/30/22 3:45 AM, Liu Song wrote: >> From: Liu Song >> >> Change "bio_set_ioprio" to inline to avoid calling overhead. > Let's not try to 2nd guess the compiler here. Most things that are > marked inline should not be. Agree, I think there is something wrong with the commit log written here, it should be expected to reduce the call overhead, bio_set_ioprio seems to be appropriate to use inline. Thanks >