From: John Garry <john.g.garry@oracle.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH 2/3] block: add helper macros to de-duplicate the queue sysfs attributes
Date: Thu, 27 Jun 2024 13:15:44 +0100 [thread overview]
Message-ID: <777c466f-e583-4669-a4e3-69a2edc16232@oracle.com> (raw)
In-Reply-To: <20240627111407.476276-3-hch@lst.de>
On 27/06/2024 12:14, Christoph Hellwig wrote:
> A lof the code to implement the queue sysfs attributes is repetitive.
lot
> Add a few macros to generate the common cases.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: John Garry <john.g.garry@oracle.com>
next prev parent reply other threads:[~2024-06-27 12:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 11:14 de-duplicate the block sysfs code Christoph Hellwig
2024-06-27 11:14 ` [PATCH 1/3] block: simplify queue_logical_block_size Christoph Hellwig
2024-06-27 12:09 ` John Garry
2024-06-27 11:14 ` [PATCH 2/3] block: add helper macros to de-duplicate the queue sysfs attributes Christoph Hellwig
2024-06-27 12:15 ` John Garry [this message]
2024-06-27 11:14 ` [PATCH 3/3] block: pass a gendisk to the queue_sysfs_entry methods Christoph Hellwig
2024-06-28 21:09 ` de-duplicate the block sysfs code Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=777c466f-e583-4669-a4e3-69a2edc16232@oracle.com \
--to=john.g.garry@oracle.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox