From: Nilay Shroff <nilay@linux.ibm.com>
To: John Garry <john.g.garry@oracle.com>,
shinichiro.kawasaki@wdc.com, linux-block@vger.kernel.org
Cc: hch@lst.de, linux-nvme@lists.infradead.org, dwagner@suse.de,
John Garry <john.garry@linux.dev>
Subject: Re: [PATCH v5] nvme/069: add a test for multipath cdev lifetime
Date: Mon, 20 Jul 2026 20:34:34 +0530 [thread overview]
Message-ID: <77f53c55-c0ad-4588-9455-0b07d9cf0367@linux.ibm.com> (raw)
In-Reply-To: <20260720150217.1355223-1-john.g.garry@oracle.com>
On 7/20/26 8:32 PM, John Garry wrote:
> In [0], a fix was proposed for the NS and NS head (multipath) cdev
> lifetime.
>
> The issue was that fds for the nvme-generic cdev may exist after we tear
> down the nvme-subsystem. Issuing an ioctl on that cdev may expose a
> use-after-free.
>
> This test recreates the method described in [0] to expose this issue
> for NS head cdev.
>
> First a fd is created by opening the nvme-generic cdev. Next we tear down
> the nvme-subsystem. Finally we try to issue an ioctl on the cdev - without
> the kernel fix in [0], this should trigger a KASAN warn.
>
> [0]https://lore.kernel.org/linux-nvme/20260713104238.3034640-1-john.g.garry@oracle.com/T/#me118851584fbcbb960795d0f04e2262e5a295613
>
> Reviewed-by: Daniel Wagner<dwagner@suse.de>
> Signed-off-by: John Garry<john.g.garry@oracle.com>
Looks good to me.
Reviewed-by: Nilay Shroff <nilay@linux.ibm.com>
next prev parent reply other threads:[~2026-07-20 15:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 15:02 [PATCH v5] nvme/069: add a test for multipath cdev lifetime John Garry
2026-07-20 15:04 ` Nilay Shroff [this message]
2026-07-23 10:05 ` Shin'ichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77f53c55-c0ad-4588-9455-0b07d9cf0367@linux.ibm.com \
--to=nilay@linux.ibm.com \
--cc=dwagner@suse.de \
--cc=hch@lst.de \
--cc=john.g.garry@oracle.com \
--cc=john.garry@linux.dev \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox