From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@redhat.com>, linux-block@vger.kernel.org
Cc: Damien Le Moal <dlemoal@kernel.org>,
Andreas Hindborg <a.hindborg@samsung.com>
Subject: Re: [PATCH] ublk: move zone report data out of request pdu
Date: Sat, 10 Aug 2024 08:26:52 -0600 [thread overview]
Message-ID: <7828bf84-ad8b-4fd5-b55e-0cd3fc320fc6@kernel.dk> (raw)
In-Reply-To: <20240810040239.437215-1-ming.lei@redhat.com>
On 8/9/24 10:02 PM, Ming Lei wrote:
> ublk zoned takes 16 bytes in each request pdu just for handling REPORT_ZONE
> operation, this way does waste memory since request pdu is allocated
> statically.
>
> Store the transient zone report data into one global xarray, and remove
> it after the report zone request is completed. This way is reasonable
> since report zone is run in slow code path.
Oof yes, that's a lot better. I think this warrants a:
Fixes: 29802d7ca33b ("ublk: enable zoned storage support")
as that's a pretty big waste, especially when most would not even be
using the zoned support.
--
Jens Axboe
next prev parent reply other threads:[~2024-08-10 14:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-10 4:02 [PATCH] ublk: move zone report data out of request pdu Ming Lei
2024-08-10 14:26 ` Jens Axboe [this message]
2024-08-11 2:03 ` Ming Lei
-- strict thread matches above, loose matches on Subject: below --
2024-08-14 9:01 Andreas Hindborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7828bf84-ad8b-4fd5-b55e-0cd3fc320fc6@kernel.dk \
--to=axboe@kernel.dk \
--cc=a.hindborg@samsung.com \
--cc=dlemoal@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox