From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@redhat.com>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH V3 00/10] block: enable multi-page bvec for passthrough IO
Date: Fri, 29 Mar 2019 08:22:31 -0600 [thread overview]
Message-ID: <782d69e3-d0f9-14ae-a57e-68d146be2f8f@kernel.dk> (raw)
In-Reply-To: <ca3a4d22-ec5a-4300-3ff2-08e0c02ed3dd@kernel.dk>
On 3/29/19 8:20 AM, Jens Axboe wrote:
> On 3/29/19 1:07 AM, Ming Lei wrote:
>> Hi,
>>
>> Now the whole IO stack is capable of handling multi-page bvec, and it has
>> been enabled in the normal FS IO path. However, it isn't done for
>> passthrough IO.
>>
>> Without enabling multi-bvec for passthough IO, we won't go ahead for
>> optimizing related IO paths, such as bvec merging, bio_add_pc_page
>> simplification.
>>
>> This patch enables multi-page bvec for passthrough IO. Turns out
>> bio_add_pc_page() is simpliefied a lot, especially the physical segment
>> number of passthrough bio is always same with bio.bi_vcnt. Also the
>> bvec merging inside bio is killed.
>>
>> blktests(block/029) is added for covering passthough IO path, and this
>> patchset does pass the new block/029 test.
>>
>> V3:
>> - fix build warning on patch 1 and 7, only the two patches are
>> changed
>
> Please just send me an incremental fix for those two patches, v2 has
> been in my tree for a while now. I can rebase it since I haven't pushed
> out, but doing so incrementally is a lot more convenient than replacing
> the entire series.
Actually, I can just replace those two, that's easy enough. Done.
--
Jens Axboe
prev parent reply other threads:[~2019-03-29 14:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 7:07 [PATCH V3 00/10] block: enable multi-page bvec for passthrough IO Ming Lei
2019-03-29 7:07 ` [PATCH V3 01/10] block: pass page to xen_biovec_phys_mergeable Ming Lei
2019-03-29 7:07 ` [PATCH V3 02/10] block: avoid to break XEN by multi-page bvec Ming Lei
2019-03-29 7:07 ` [PATCH V3 03/10] block: don't merge adjacent bvecs to one segment in bio blk_queue_split Ming Lei
2019-03-29 7:07 ` [PATCH V3 04/10] block: cleanup bio_add_pc_page Ming Lei
2019-03-29 7:07 ` [PATCH V3 05/10] block: check if page is mergeable in one helper Ming Lei
2019-03-29 7:07 ` [PATCH V3 06/10] block: put the same page when adding it to bio Ming Lei
2019-03-29 7:08 ` [PATCH V3 07/10] block: enable multi-page bvec for passthrough IO Ming Lei
2019-03-29 7:08 ` [PATCH V3 08/10] block: remove argument of 'request_queue' from __blk_bvec_map_sg Ming Lei
2019-03-29 7:08 ` [PATCH V3 09/10] block: reuse __blk_bvec_map_sg() for mapping page sized bvec Ming Lei
2019-03-29 7:08 ` [PATCH V3 10/10] block: don't check if adjacent bvecs in one bio can be mergeable Ming Lei
2019-03-29 14:20 ` [PATCH V3 00/10] block: enable multi-page bvec for passthrough IO Jens Axboe
2019-03-29 14:22 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=782d69e3-d0f9-14ae-a57e-68d146be2f8f@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox