From: Jens Axboe <axboe@kernel.dk>
To: Breno Leitao <leitao@debian.org>,
io-uring@vger.kernel.org, linux-nvme@lists.infradead.org,
asml.silence@gmail.com
Cc: leit@fb.com, linux-kernel@vger.kernel.org,
linux-block@vger.kernel.org, sagi@grimberg.me, hch@lst.de,
kbusch@kernel.org, ming.lei@redhat.com
Subject: Re: [PATCH v2 3/3] io_uring: Remove unnecessary BUILD_BUG_ON
Date: Fri, 28 Apr 2023 11:27:30 -0600 [thread overview]
Message-ID: <786c3e8c-5fc3-9ee0-e026-e32a4b061eee@kernel.dk> (raw)
In-Reply-To: <20230421114440.3343473-4-leitao@debian.org>
On 4/21/23 5:44?AM, Breno Leitao wrote:
> In the io_uring_cmd_prep_async() there is a unnecessary compilation time
> check to check if cmd is correctly placed at field 48 of the SQE.
>
> This is uncessary, since this check is already in place at
> io_uring_init():
>
> BUILD_BUG_SQE_ELEM(48, __u64, addr3);
>
> Remove it and the uring_cmd_pdu_size() function, which is not used
> anymore.
>
> Keith started a discussion about this topic in the following thread:
> https://lore.kernel.org/lkml/ZDBmQOhbyU0iLhMw@kbusch-mbp.dhcp.thefacebook.com/
Just turn that into a:
Link: https://lore.kernel.org/lkml/ZDBmQOhbyU0iLhMw@kbusch-mbp.dhcp.thefacebook.com/
instead.
--
Jens Axboe
next prev parent reply other threads:[~2023-04-28 17:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230421114703epcas5p37cd0ddb29674d8f3d5fe2f1fa494d1f0@epcas5p3.samsung.com>
2023-04-21 11:44 ` [PATCH v2 0/3] io_uring: Pass the whole sqe to commands Breno Leitao
2023-04-21 11:44 ` [PATCH v2 1/3] io_uring: Create a helper to return the SQE size Breno Leitao
2023-04-24 7:19 ` Christoph Hellwig
2023-04-21 11:44 ` [PATCH v2 2/3] io_uring: Pass whole sqe to commands Breno Leitao
2023-04-24 7:23 ` Christoph Hellwig
2023-04-21 11:44 ` [PATCH v2 3/3] io_uring: Remove unnecessary BUILD_BUG_ON Breno Leitao
2023-04-24 7:23 ` Christoph Hellwig
2023-04-28 17:27 ` Jens Axboe [this message]
2023-04-21 12:16 ` [PATCH v2 0/3] io_uring: Pass the whole sqe to commands Kanchan Joshi
2023-04-28 17:28 ` Jens Axboe
2023-04-30 14:39 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=786c3e8c-5fc3-9ee0-e026-e32a4b061eee@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=hch@lst.de \
--cc=io-uring@vger.kernel.org \
--cc=kbusch@kernel.org \
--cc=leit@fb.com \
--cc=leitao@debian.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).