From: Jens Axboe <axboe@fb.com>
To: Josef Bacik <jbacik@fb.com>, <linux-block@vger.kernel.org>
Subject: Re: [PATCH] nbd: only set MSG_MORE when we have more to send
Date: Thu, 19 Jan 2017 13:32:39 -0800 [thread overview]
Message-ID: <79f127ad-aadd-ed49-a60e-d7d36acfcc6d@fb.com> (raw)
In-Reply-To: <1484860129-14727-1-git-send-email-jbacik@fb.com>
On 01/19/2017 01:08 PM, Josef Bacik wrote:
> A user noticed that write performance was horrible over loopback and we
> traced it to an inversion of when we need to set MSG_MORE. It should be
> set when we have more bvec's to send, not when we are on the last bvec.
> This patch made the test go from 20 iops to 78k iops.
Added for 4.10, thanks.
--
Jens Axboe
prev parent reply other threads:[~2017-01-19 21:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 21:08 [PATCH] nbd: only set MSG_MORE when we have more to send Josef Bacik
2017-01-19 21:32 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79f127ad-aadd-ed49-a60e-d7d36acfcc6d@fb.com \
--to=axboe@fb.com \
--cc=jbacik@fb.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox