Re: [PATCH v3 2/2] dm: Improve zone resource limits handling

Damien Le Moal
2024-06-05T06:55:09Z

On 6/5/24 15:49, Christoph Hellwig wrote:
>> + /*
>> + * If the limits are larger than the number of mapped sequential zones,
>> + * assume no limits. Note that blk_revalidate_disk_zones() also executes
>> + * this adjustment, but only for mapped devices that use zone write
>> + * plugging, that is, for mapped devices needing zone append emulation.
>> + * So for DM devices using native zone append of the target devices, we
>> + * need to adjust the zone resource limits here.
>> + */
>> + if (lim->max_active_zones > zlim.mapped_nr_seq_zones)
>> + lim->max_active_zones = 0;
>> + if (lim->max_open_zones > zlim.mapped_nr_seq_zones)
>> + lim->max_open_zones = 0;
>
> Is there any good reason to not just do this unconditionally in common
> code?

I can. I need to tweak the early return for the case where the DM device does
not use zone write plugging. Let me do that.

--
Damien Le Moal
Western Digital Research