From: Damien Le Moal <dlemoal@kernel.org>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: Ming Lei <ming.lei@redhat.com>,
Nilay Shroff <nilay@linux.ibm.com>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
nbd@other.debian.org, linux-scsi@vger.kernel.org,
usb-storage@lists.one-eyed-alien.net
Subject: Re: [PATCH 4/8] block: add a store_limit operations for sysfs entries
Date: Tue, 7 Jan 2025 19:05:22 +0900 [thread overview]
Message-ID: <7b657b32-dd25-4826-9c2f-dfd980610de2@kernel.org> (raw)
In-Reply-To: <20250107063120.1011593-5-hch@lst.de>
On 1/7/25 15:30, Christoph Hellwig wrote:
> De-duplicate the code for updating queue limits by adding a store_limit
> method that allows having common code handle the actual queue limits
> update.
>
> Note that this is a pure refactoring patch and does not address the
> existing freeze vs limits lock order problem in the refactored code,
> which will be addressed next.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2025-01-07 10:05 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-07 6:30 fix queue freeze and limit locking order Christoph Hellwig
2025-01-07 6:30 ` [PATCH 1/8] block: fix docs for freezing of queue limits updates Christoph Hellwig
2025-01-07 7:01 ` Nilay Shroff
2025-01-07 18:05 ` Nilay Shroff
2025-01-07 10:03 ` Damien Le Moal
2025-01-09 11:19 ` John Garry
2025-01-09 11:24 ` Nilay Shroff
2025-01-09 11:26 ` John Garry
2025-01-07 6:30 ` [PATCH 2/8] block: add a queue_limits_commit_update_frozen helper Christoph Hellwig
2025-01-07 10:05 ` Damien Le Moal
2025-01-07 17:58 ` Nilay Shroff
2025-01-07 6:30 ` [PATCH 3/8] block: don't update BLK_FEAT_POLL in __blk_mq_update_nr_hw_queues Christoph Hellwig
2025-01-07 6:57 ` Nilay Shroff
2025-01-07 8:21 ` Christoph Hellwig
2025-01-07 9:23 ` Nilay Shroff
2025-01-07 13:51 ` Christoph Hellwig
2025-01-07 17:55 ` Nilay Shroff
2025-01-07 6:30 ` [PATCH 4/8] block: add a store_limit operations for sysfs entries Christoph Hellwig
2025-01-07 7:25 ` Ming Lei
2025-01-07 7:51 ` Nilay Shroff
2025-01-07 8:26 ` Christoph Hellwig
2025-01-07 10:25 ` Ming Lei
2025-01-07 13:49 ` Christoph Hellwig
2025-01-07 8:23 ` Christoph Hellwig
2025-01-07 10:05 ` Damien Le Moal [this message]
2025-01-07 17:58 ` Nilay Shroff
2025-01-07 6:30 ` [PATCH 5/8] block: fix queue freeze vs limits lock order in sysfs store methods Christoph Hellwig
2025-01-07 17:59 ` Nilay Shroff
2025-01-07 6:30 ` [PATCH 6/8] nvme: fix queue freeze vs limits lock order Christoph Hellwig
2025-01-07 6:58 ` Nilay Shroff
2025-01-07 8:22 ` Christoph Hellwig
2025-01-07 8:45 ` Nilay Shroff
2025-01-07 8:58 ` Christoph Hellwig
2025-01-07 9:29 ` Nilay Shroff
2025-01-07 9:58 ` Damien Le Moal
2025-01-07 18:00 ` Nilay Shroff
2025-01-07 6:30 ` [PATCH 7/8] nbd: " Christoph Hellwig
2025-01-07 10:00 ` Damien Le Moal
2025-01-07 18:01 ` Nilay Shroff
2025-01-07 6:30 ` [PATCH 8/8] usb-storage:fix " Christoph Hellwig
2025-01-07 10:00 ` Damien Le Moal
2025-01-07 18:01 ` Nilay Shroff
2025-01-08 2:21 ` fix queue freeze and limit locking order Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b657b32-dd25-4826-9c2f-dfd980610de2@kernel.org \
--to=dlemoal@kernel.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=nbd@other.debian.org \
--cc=nilay@linux.ibm.com \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).