From: Bart Van Assche <bvanassche@acm.org>
To: "Ionut Nechita (Wind River)" <ionut.nechita@windriver.com>,
linux-block@vger.kernel.org, axboe@kernel.dk
Cc: bigeasy@linutronix.de, clrkwllms@kernel.org, rostedt@goodmis.org,
ming.lei@redhat.com, muchun.song@linux.dev,
mkhalfella@purestorage.com, chris.friesen@windriver.com,
linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev,
linux-rt-users@vger.kernel.org, stable@vger.kernel.org,
ionut_n2001@yahoo.com, sunlightlinux@gmail.com
Subject: Re: [PATCH v5 1/1] block/blk-mq: use atomic_t for quiesce_depth to avoid lock contention on RT
Date: Tue, 5 May 2026 17:41:55 +0200 [thread overview]
Message-ID: <7c811a44-6d7e-499c-8203-90a256984912@acm.org> (raw)
In-Reply-To: <20260303073744.20585-2-ionut.nechita@windriver.com>
On 3/3/26 8:37 AM, Ionut Nechita (Wind River) wrote:
> + /*
> + * Ensure the store to quiesce_depth is visible before any
> + * subsequent loads in blk_mq_run_hw_queue().
> + */
This comment does not make sense to me. How could there be a dependency
of blk_mq_run_hw_queue() on *loads* that happen in
blk_mq_quiesce_queue_nowait() after atomic_inc(&q->quiesce_depth)?
Bart.
next prev parent reply other threads:[~2026-05-05 15:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 7:37 [PATCH v5 0/1] block/blk-mq: use atomic_t for quiesce_depth to avoid lock contention on RT Ionut Nechita (Wind River)
2026-03-03 7:37 ` [PATCH v5 1/1] " Ionut Nechita (Wind River)
2026-05-05 15:41 ` Bart Van Assche [this message]
2026-05-05 15:03 ` [PATCH v5 0/1] " Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c811a44-6d7e-499c-8203-90a256984912@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=bigeasy@linutronix.de \
--cc=chris.friesen@windriver.com \
--cc=clrkwllms@kernel.org \
--cc=ionut.nechita@windriver.com \
--cc=ionut_n2001@yahoo.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=linux-rt-users@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=mkhalfella@purestorage.com \
--cc=muchun.song@linux.dev \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
--cc=sunlightlinux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox