From: Bart Van Assche <bvanassche@acm.org>
To: Dongliang Cui <dongliang.cui@unisoc.com>,
axboe@kernel.dk, rostedt@goodmis.org, mhiramat@kernel.org,
mathieu.desnoyers@efficios.com, ebiggers@kernel.org
Cc: ke.wang@unisoc.com, hongyu.jin.cn@gmail.com,
niuzhiguo84@gmail.com, hao_hao.wang@unisoc.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
akailash@google.com, cuidongliang390@gmail.com
Subject: Re: [PATCH v5] block: Add ioprio to block_rq tracepoint
Date: Fri, 14 Jun 2024 09:40:56 -0700 [thread overview]
Message-ID: <7d0f68b8-ecdb-45fb-ae10-954eac5ed32c@acm.org> (raw)
In-Reply-To: <20240614074936.113659-1-dongliang.cui@unisoc.com>
On 6/14/24 12:49 AM, Dongliang Cui wrote:
> - TP_printk("%d,%d %s (%s) %llu + %u [%d]",
> + TP_printk("%d,%d %s (%s) %llu + %u %s,%u,%u [%d]",
> MAJOR(__entry->dev), MINOR(__entry->dev),
> __entry->rwbs, __get_str(cmd),
> - (unsigned long long)__entry->sector,
> - __entry->nr_sector, 0)
> + (unsigned long long)__entry->sector, __entry->nr_sector,
> + __print_symbolic(IOPRIO_PRIO_CLASS(__entry->ioprio),
> + IOPRIO_CLASS_STRINGS),
> + IOPRIO_PRIO_HINT(__entry->ioprio),
> + IOPRIO_PRIO_LEVEL(__entry->ioprio), 0)
> );
Do we really want to include the constant "[0]" in the tracing output?
Otherwise this patch looks good to me.
Thanks,
Bart.
next prev parent reply other threads:[~2024-06-14 16:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 7:49 [PATCH v5] block: Add ioprio to block_rq tracepoint Dongliang Cui
2024-06-14 16:40 ` Bart Van Assche [this message]
2024-06-17 7:59 ` dongliang cui
2024-06-17 17:02 ` Bart Van Assche
2024-06-17 17:07 ` Steven Rostedt
2024-06-17 21:30 ` Bart Van Assche
2024-06-18 0:28 ` Chaitanya Kulkarni
2024-06-28 6:38 ` dongliang cui
2024-06-28 16:36 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d0f68b8-ecdb-45fb-ae10-954eac5ed32c@acm.org \
--to=bvanassche@acm.org \
--cc=akailash@google.com \
--cc=axboe@kernel.dk \
--cc=cuidongliang390@gmail.com \
--cc=dongliang.cui@unisoc.com \
--cc=ebiggers@kernel.org \
--cc=hao_hao.wang@unisoc.com \
--cc=hongyu.jin.cn@gmail.com \
--cc=ke.wang@unisoc.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=niuzhiguo84@gmail.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).