From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75B4F548557 for ; Wed, 14 Oct 2026 16:43:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791996209; cv=none; b=V9hN+hNZo8WQtsCEqJA9ArKaQ49PaF7RrO84UUOT68/koJwJV5aK96i1b8R9WihRykBIykQFjV2D1lYuQHf0o11+7XlLM3VaC8I3BdfTXFdHN39UIc3QRMD3rodjqKUeVuhRKfa3xP/104jAZga+/8vg1/3ujoseS/MXAhCmPvo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791996209; c=relaxed/simple; bh=inWFXH/4gvwDDJShSxb1UbDeXwomoSCtPfVrGbG9V30=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ScijUS4pPvoiPIlzianb2mq31+7Cr7l5p/QouAqbYQnDhbnVV8VrS6DvBsZNaciDRrmWbkB3sLve8815I4i7SjOByWmIxPw5GgLa1lpluccpC4eVkxc3yAEwIVy4azMP8yda+FLoTL2a2b2I5QfjwjfjC/gyg+OV5mv30wb8m2U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=E1NM3HAv; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E1NM3HAv" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4a16c1608faso57221895e9.0 for ; Wed, 14 Oct 2026 09:43:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791996207; x=1792601007; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MprqRVTku8rnnoqrNidogE79Hh/sbjcVtJHMk6QO0CA=; b=E1NM3HAvhNi9WchZCxi00OWvzNXWTS2u9u46iCZ3ECQeHnpGaWCZkd2cly+63fqf9N vCRSfhbNX4pSk9hS9CdsqxtJ9Ct3kD9jrt77wBkSBXF+cbMZ9YyJCbxsApFjfxGwVHkQ 9mI97SUREXrgYZjUWhNcorUK/AhUkfbW+kAiYYRCscCCfVyE99IvI5Lvc+isggf0hntX ILRq77IJjxILg2lW57G4jEGwEYrprjfZgboCuATbf849dHnvs/BT/5NTChKw9SrVwSYC ojaj/o0+U59n8OjEQVffo6tw80KC9ygURz8nKf7xjhnzzmTKJzZNJFGetkIgcLFaC/NG GqFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791996207; x=1792601007; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MprqRVTku8rnnoqrNidogE79Hh/sbjcVtJHMk6QO0CA=; b=o32Rxo6qadOH8gXdu65siqvaglvC6uVBnqcB8GT5Iu6vc0Wlk9h/u8tUrxNt4KwD0l 5wvEQXGe+CuolFh5sU5h0M9p9kj1i+/M5MQtV31zeAdqcdmmVUA+YCFpgERyMGf+Ctsl r0w2F2tq72waMSIYItAKfjZaySHS3QDq+ednXnPxIJ3EevLbMMsciNpkT4mdw9JKl5cR CzRwmE9vhwV5zW/YeqHYUlYMvQaZdXHa8F6hrRXkVP2OgoCT1K+JFbcT2pYrykRYvl+Z TTfJiiCZbydXK9DA6povzoy11BWy107ib7mC3CmHM8v1yAwaXBP9fyMYJ/Ebi93Px16a DSDg== X-Gm-Message-State: AFq9FYL2RAEtpBRxi8WQSLb2sF3DxZdHKeOm7d0X/7hYYMNn4b59DlVG cNXiM4ekLk6tncnobyh2UVC5Ik4QFOgY3k3w8aeaDh2ZSEvOHzfM8sZ1 X-Gm-Gg: AYBFou0D3kfKxvuiJ6xEEQdTS/tzLa6PFK41jPySfj5HbSC5Jwyvw5fRKUZunF/6KIF ZYvyXcWOh+QnbVdeMx6X3rPyJVglTNpMzwPJQj9eFwMo4Hv5kNJwoO+zFx0fmRaMuOQioD1HhkH MrI1e9+jhcVXRnJQrxtVelBRuMPxTqH2EiGL5/JPAVZBvMdUVD0zzXBO7oXDgNqyJUqbWkJY8fV 0H9/e3yoae6NCPEMf0YL4Klf9xcWRNpf+FeSoXb8W8x/0nUq3r26K20ErgNREdgGJg9QKQFmTYk kGmjrN5nAVIWUTR4y2starKQyln7xaCHcG27FvJYkAbyuAHo8KVpk3+mDvY2rRbwYHaPi0qeDYT sj4T6ma/FLTXHcFK05Gv8mXcpvMdGaWCbqWhhx49IGzle60DfE5IwVzgRBgPaPS8XZ9MKGy2DHa +24947m6qXsPpIqKj0jrUa4DvCFeK+htHAkCXdsgP32hLue1W7Hcd+0d+pDmaVUv+KbAPOUkQ/S 0uCODzyA8yJjgmIoYL578dc/TzY6owqgVQAwlo17NjKlai3NMsdo0Jmh9bUJAY4CxzjRhpOo8L4 sppmnE7uLn+GuTfEyNF8UhfglrfqZVBj1UXmashQQ9S+AdIw X-Received: by 2002:a05:600c:83cf:b0:4a1:ac66:604b with SMTP id 5b1f17b1804b1-4a1ac666a65mr120408565e9.1.1791996206748; Wed, 14 Oct 2026 09:43:26 -0700 (PDT) Received: from ?IPV6:2a01:4b00:bd21:4f00:7cc6:d3ca:494:116c? ([2a01:4b00:bd21:4f00:7cc6:d3ca:494:116c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a1bd640be0sm4751135e9.1.2026.10.14.09.43.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Oct 2026 09:43:24 -0700 (PDT) Message-ID: <7d3c3cc3-5c7b-4d28-82d8-2cdb5e010c29@gmail.com> Date: Wed, 14 Oct 2026 17:43:20 +0100 Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11 04/13] block: introduce dma map backed bio type To: Christoph Hellwig Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , Keith Busch , Sagi Grimberg , Alexander Viro , Christian Brauner , Jan Kara , Andrew Morton , Jens Axboe , Nitesh Shetty , Kanchan Joshi , Anuj Gupta , Tushar Gohad , William Power , Matthew Brost , Alasdair Kergon , Mike Snitzer , Mikulas Patocka , Benjamin Marzinski , dm-devel@lists.linux.dev References: <39b964cf7510f42755188563da63d3d5acaf2aa9.1791975048.git.asml.silence@gmail.com> <20261014131554.GA16467@lst.de> Content-Language: en-US From: Pavel Begunkov In-Reply-To: <20261014131554.GA16467@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/14/26 14:15, Christoph Hellwig wrote: > On Wed, Oct 14, 2026 at 12:02:02PM +0100, Pavel Begunkov wrote: ...>> case REQ_OP_DISCARD: >> diff --git a/block/blk-mq.c b/block/blk-mq.c >> index e929f94b25c7..1b7f8cbbda8b 100644 >> --- a/block/blk-mq.c >> +++ b/block/blk-mq.c >> @@ -3150,6 +3150,12 @@ void blk_mq_submit_bio(struct bio *bio) >> goto queue_exit; >> } >> >> + if (unlikely(op_is_dmabuf(bio->bi_opf) && >> + bdev_has_integrity_csum(bio->bi_bdev))) { >> + bio_endio_status(bio, BLK_STS_NOTSUPP); > > Wrong indentation, conditions are never indented the same level as > the following code block, even with the weirdest preferences. > > /me note the patch from Anuj on the list actually got this right.. I had to split Anuj's patch in two, should've butchered it while hand applying. I'll follow up on that unless Jens already applied the change. > Otherwise looks good: > > Reviewed-by: Christoph Hellwig -- Pavel Begunkov