From: Jens Axboe <axboe@kernel.dk>
To: "Dan Carpenter" <dan.carpenter@oracle.com>,
"Matias Bjorling" <mb@lightnvm.io>,
"Javier González" <jg@lightnvm.io>
Cc: linux-block@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2] lightnvm: don't print a warning for ADDR_EMPTY
Date: Fri, 21 Apr 2017 16:50:55 -0600 [thread overview]
Message-ID: <7db94fa9-302e-50fb-14cc-f8917cfeed5e@kernel.dk> (raw)
In-Reply-To: <20170421205437.fom72nbe3rfngdra@mwanda>
On 04/21/2017 02:54 PM, Dan Carpenter wrote:
> Reading from ADDR_EMPTY is out of bounds. The current code generates a
> static checker warning because we check for out of bounds "lba" before
> we check for ADDR_EMPTY, so the second check is always false. It looks
> like we intended ADDR_EMPTY to be a no-op without printing a warning.
>
> Fixes: a4bd217b4326 ("lightnvm: physical block device (pblk) target")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Added, thanks Dan.
--
Jens Axboe
prev parent reply other threads:[~2017-04-21 22:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 20:54 [PATCH 2/2] lightnvm: don't print a warning for ADDR_EMPTY Dan Carpenter
2017-04-21 22:33 ` Javier González
2017-04-21 22:50 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7db94fa9-302e-50fb-14cc-f8917cfeed5e@kernel.dk \
--to=axboe@kernel.dk \
--cc=dan.carpenter@oracle.com \
--cc=jg@lightnvm.io \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=mb@lightnvm.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox