From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4375ECAAD8 for ; Tue, 30 Aug 2022 07:44:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230194AbiH3Hoq (ORCPT ); Tue, 30 Aug 2022 03:44:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229842AbiH3Hop (ORCPT ); Tue, 30 Aug 2022 03:44:45 -0400 Received: from out0.migadu.com (out0.migadu.com [94.23.1.103]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB5E7A2226 for ; Tue, 30 Aug 2022 00:44:42 -0700 (PDT) Message-ID: <7e3252ca-c713-ceff-a960-33378534aadf@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1661845481; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jnv2ZmZIrMdU4+ORBQMYYqeQ5sYAavk3951y4o5SGNY=; b=OachzibjkZ7tqJWWlqW3xHbGsQeyPfJRy/EJ3iShT2ay8ufpunPbmtId1dhY8WlFlVpRyK v7ysOacN3u4O7ppRw9GGbNtHKobQzqikJl4M05pcrk/f0F3CqQEU1ObrjlnfUShxwmWfrS LQzyw9QWUnaaSeFaQpXTXSS0WU/HX/0= Date: Tue, 30 Aug 2022 15:44:31 +0800 MIME-Version: 1.0 Subject: Re: [PATCH blktests] nvme: add dh module requirement for tests that involve dh groups Content-Language: en-US To: Sagi Grimberg , Shinichiro Kawasaki Cc: "linux-nvme@lists.infradead.org" , "linux-block@vger.kernel.org" , Hannes Reinecke References: <20220829083614.874878-1-sagi@grimberg.me> <20220830044632.j7k45lhdlyvksrxh@shindev> <05548286-8d18-e3b4-06db-640c9d6b1399@grimberg.me> <9e623544-8954-4b62-e97c-d5917fb43937@grimberg.me> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Jackie Liu In-Reply-To: <9e623544-8954-4b62-e97c-d5917fb43937@grimberg.me> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org My fault, my config file becomes y because NVME_CORE is also y. sorry to bother you. -- Jackie Liu 在 2022/8/30 15:37, Sagi Grimberg 写道: > >> Hi Sagi. >> >> 在 2022/8/30 15:05, Sagi Grimberg 写道: >>> >>>> Hi Sagi, >>>> >>>> On Aug 29, 2022 / 11:36, Sagi Grimberg wrote: >>>>> Signed-off-by: Sagi Grimberg >>>>> --- >>>>>   tests/nvme/043 | 1 + >>>>>   tests/nvme/044 | 1 + >>>>>   tests/nvme/045 | 1 + >>>>>   3 files changed, 3 insertions(+) >>>>> >>>>> diff --git a/tests/nvme/043 b/tests/nvme/043 >>>>> index 381ae755f140..87273e5b414d 100755 >>>>> --- a/tests/nvme/043 >>>>> +++ b/tests/nvme/043 >>>>> @@ -16,6 +16,7 @@ requires() { >>>>>       _have_kernel_option NVME_TARGET_AUTH >>>>>       _require_nvme_trtype_is_fabrics >>>>>       _require_nvme_cli_auth >>>>> +    _have_driver dh_generic >>>>>   } >>>> >>>> Do you see failure without this check? >>> >>> Yes, if dh_generic is built as a module (CONFIG_CRYPTO_DH=m). >> >> Maybe I don't understand correctly, but I think when NVME_AUTH=y >> CONFIG_CRYPTO_DH can only be built in. >> > > No. > > In my .config: > -- > ... > # > # NVME Support > # > CONFIG_NVME_COMMON=m > CONFIG_NVME_CORE=m > CONFIG_BLK_DEV_NVME=m > CONFIG_NVME_MULTIPATH=y > # CONFIG_NVME_VERBOSE_ERRORS is not set > CONFIG_NVME_HWMON=y > CONFIG_NVME_FABRICS=m > CONFIG_NVME_RDMA=m > CONFIG_NVME_FC=m > CONFIG_NVME_TCP=m > CONFIG_NVME_AUTH=y > CONFIG_NVME_TARGET=m > CONFIG_NVME_TARGET_PASSTHRU=y > CONFIG_NVME_TARGET_LOOP=m > CONFIG_NVME_TARGET_RDMA=m > CONFIG_NVME_TARGET_FC=m > CONFIG_NVME_TARGET_FCLOOP=m > CONFIG_NVME_TARGET_TCP=m > CONFIG_NVME_TARGET_AUTH=y > # end of NVME Support > ... > # > # Public-key cryptography > # > CONFIG_CRYPTO_RSA=y > CONFIG_CRYPTO_DH=m > CONFIG_CRYPTO_DH_RFC7919_GROUPS=y > CONFIG_CRYPTO_ECC=m > CONFIG_CRYPTO_ECDH=m > # CONFIG_CRYPTO_ECDSA is not set > # CONFIG_CRYPTO_ECRDSA is not set > # CONFIG_CRYPTO_SM2 is not set > # CONFIG_CRYPTO_CURVE25519 is not set > # CONFIG_CRYPTO_CURVE25519_X86 is not set > --