From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>,
Keith Busch <kbusch@kernel.org>, Sagi Grimberg <sagi@grimberg.me>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/4] blk-mq: move the call to blk_put_queue out of blk_mq_destroy_queue
Date: Tue, 25 Oct 2022 08:25:58 -0600 [thread overview]
Message-ID: <7e9c2c88-2fe4-d48e-dabf-3fa345bcc8e6@kernel.dk> (raw)
In-Reply-To: <2baca1bc-cee0-9a52-3fcd-bdb812e5f512@kernel.dk>
On 10/25/22 8:23 AM, Jens Axboe wrote:
>> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
>> index 059737c1a2c19..07381673170b9 100644
>> --- a/drivers/nvme/host/core.c
>> +++ b/drivers/nvme/host/core.c
>> @@ -4847,6 +4847,7 @@ int nvme_alloc_admin_tag_set(struct nvme_ctrl *ctrl, struct blk_mq_tag_set *set,
>>
>> out_cleanup_admin_q:
>> blk_mq_destroy_queue(ctrl->fabrics_q);
>> + blk_put_queue(ctrl->fabrics_q);
>> out_free_tagset:
>> blk_mq_free_tag_set(ctrl->admin_tagset);
>> return ret;
> This is wrong and doesn't apply because it got fixed upstream:
>
> commit 4739824e2d7878dcea88397a6758e31e3c5c124e
> Author: Dan Carpenter <error27@gmail.com>
> Date: Sat Oct 15 11:25:56 2022 +0300
>
> nvme: fix error pointer dereference in error handling
>
> Can you respin this series so we can get it applied?
I just made the trivial edit in the patch itself, rest was
fine.
--
Jens Axboe
next prev parent reply other threads:[~2022-10-25 14:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 13:57 don't drop the queue reference in blk_mq_destroy_queue Christoph Hellwig
2022-10-18 13:57 ` [PATCH 1/4] blk-mq: move the call to blk_put_queue out of blk_mq_destroy_queue Christoph Hellwig
2022-10-18 20:44 ` Chaitanya Kulkarni
2022-10-19 8:19 ` Sagi Grimberg
2022-10-25 14:23 ` Jens Axboe
2022-10-25 14:25 ` Jens Axboe [this message]
2022-10-18 13:57 ` [PATCH 2/4] scsi: remove an extra queue reference Christoph Hellwig
2022-10-18 20:44 ` Chaitanya Kulkarni
2022-10-19 1:16 ` Ming Lei
2022-10-19 1:23 ` Ming Lei
2022-10-19 8:19 ` Sagi Grimberg
2022-10-18 13:57 ` [PATCH 3/4] nvme-pci: " Christoph Hellwig
2022-10-18 20:44 ` Chaitanya Kulkarni
2022-10-19 8:19 ` Sagi Grimberg
2022-10-18 13:57 ` [PATCH 4/4] nvme-apple: " Christoph Hellwig
2022-10-18 17:51 ` Sven Peter
2022-10-18 20:45 ` Chaitanya Kulkarni
2022-10-19 8:19 ` Sagi Grimberg
2022-10-18 15:16 ` don't drop the queue reference in blk_mq_destroy_queue Keith Busch
2022-10-25 14:26 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e9c2c88-2fe4-d48e-dabf-3fa345bcc8e6@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=martin.petersen@oracle.com \
--cc=sagi@grimberg.me \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox