* [PATCH -next] block: make function __bio_integrity_free() static
@ 2020-07-02 1:48 Wei Yongjun
2020-07-02 4:18 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2020-07-02 1:48 UTC (permalink / raw)
To: Hulk Robot, Jens Axboe; +Cc: linux-block
From: Hulk Robot <hulkci@huawei.com>
Fix sparse build warning:
block/bio-integrity.c:27:6: warning:
symbol '__bio_integrity_free' was not declared. Should it be static?
Signed-off-by: Hulk Robot <hulkci@huawei.com>
---
block/bio-integrity.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/bio-integrity.c b/block/bio-integrity.c
index 4707e90b8ee5..9ffd7e289554 100644
--- a/block/bio-integrity.c
+++ b/block/bio-integrity.c
@@ -24,7 +24,8 @@ void blk_flush_integrity(void)
flush_workqueue(kintegrityd_wq);
}
-void __bio_integrity_free(struct bio_set *bs, struct bio_integrity_payload *bip)
+static void __bio_integrity_free(struct bio_set *bs,
+ struct bio_integrity_payload *bip)
{
if (bs && mempool_initialized(&bs->bio_integrity_pool)) {
if (bip->bip_vec)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] block: make function __bio_integrity_free() static
2020-07-02 1:48 [PATCH -next] block: make function __bio_integrity_free() static Wei Yongjun
@ 2020-07-02 4:18 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2020-07-02 4:18 UTC (permalink / raw)
To: Wei Yongjun, Hulk Robot; +Cc: linux-block
On 7/1/20 7:48 PM, Wei Yongjun wrote:
> From: Hulk Robot <hulkci@huawei.com>
This patch (and the other you sent) both look fine and correct, but
this doesn't look like a real persons name. Can you attribute the
patch to yourself instead? I can't use a CI name.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-02 4:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-02 1:48 [PATCH -next] block: make function __bio_integrity_free() static Wei Yongjun
2020-07-02 4:18 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).