Re: [PATCH v5 07/11] block: mq-deadline: Improve deadline_skip_seq_writes()

[Damien Le Moal <dlemoal@kernel.org>]

On 5/17/23 16:41, Hannes Reinecke wrote:
> On 5/17/23 00:33, Bart Van Assche wrote:
>> Make deadline_skip_seq_writes() do what its name suggests, namely to
>> skip sequential writes.
>>
>> Reviewed-by: Christoph Hellwig <hch@lst.de>
>> Cc: Damien Le Moal <damien.lemoal@opensource.wdc.com>
>> Cc: Ming Lei <ming.lei@redhat.com>
>> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
>> ---
>>   block/mq-deadline.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/block/mq-deadline.c b/block/mq-deadline.c
>> index 6276afede9cd..dbc0feca963e 100644
>> --- a/block/mq-deadline.c
>> +++ b/block/mq-deadline.c
>> @@ -308,7 +308,7 @@ static struct request *deadline_skip_seq_writes(struct deadline_data *dd,
>>   	do {
>>   		pos += blk_rq_sectors(rq);
>>   		rq = deadline_latter_request(rq);
>> -	} while (rq && blk_rq_pos(rq) == pos);
>> +	} while (rq && blk_rq_pos(rq) == pos && blk_rq_is_seq_zoned_write(rq));
>>   
>>   	return rq;
>>   }
> 
> Please merge it with the previous patch.

Please no. Let's drop this change.

> 
> Cheers,
> 
> Hannes

-- 
Damien Le Moal
Western Digital Research