Re: [PATCH v2] block: BFQ default for single queue devices

Linus Walleij
2018-10-19T08:33:47Z

On Mon, Oct 15, 2018 at 4:32 PM Oleksandr Natalenko
<oleksandr@natalenko.name> wrote:
> On 15.10.2018 16:10, Linus Walleij wrote:

> > + /*
> > + * Zoned devices must use a deadline scheduler because currently
> > + * that is the only scheduler respecting zoned writes.
> > + */
> > + if (blk_queue_is_zoned(q))
> > + policy = "mq-deadline";
> > + else if (IS_ENABLED(CONFIG_IOSCHED_BFQ))
> > + policy = "bfq";
> > + else
> > + policy = "mq-deadline";
>
> If more rules will be needed in the future, shall we just add extra ifs,
> or it would be better to craft some struct/table now + policy search
> helper?

Let's do it when it happens. Premature optimization is the root
of all evil ;)

Yours,
Linus Walleij