From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@redhat.com>, linux-block@vger.kernel.org
Cc: Christoph Hellwig <hch@lst.de>,
Eric Dumazet <edumazet@google.com>,
syzbot+71abe7ab2b70bca770fd@syzkaller.appspotmail.com
Subject: Re: [PATCH] lib/iov_iter: fix bvec iterator setup
Date: Sat, 2 Nov 2024 08:45:20 -0600 [thread overview]
Message-ID: <801bf877-542e-46ed-a13c-bfc8bf133bd1@kernel.dk> (raw)
In-Reply-To: <20241102014211.348731-1-ming.lei@redhat.com>
On 11/1/24 7:42 PM, Ming Lei wrote:
> .bi_size of bvec iterator should be initialized as real max size for
> walking, and .bi_bvec_done just counts how many bytes need to be
> skipped in the 1st bvec, so .bi_size isn't related with .bi_bvec_done.
>
> This patch fixes bvec iterator initialization, and the inner `size`
> check isn't needed any more, so revert Eric Dumazet's commit
> 7bc802acf193 ("iov-iter: do not return more bytes than requested in
> iov_iter_extract_bvec_pages()").
>
> Cc: Eric Dumazet <edumazet@google.com>
> Fixes: e4e535bff2bc ("iov_iter: don't require contiguous pages in iov_iter_extract_bvec_pages")
> Reported-by: syzbot+71abe7ab2b70bca770fd@syzkaller.appspotmail.com
> Tested-by: syzbot+71abe7ab2b70bca770fd@syzkaller.appspotmail.com
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> ---
> Hi Jens,
>
> If possible, please merge this one with Eric's commit.
I can just swap them out.
--
Jens Axboe
prev parent reply other threads:[~2024-11-02 14:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-02 1:42 [PATCH] lib/iov_iter: fix bvec iterator setup Ming Lei
2024-11-02 14:45 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=801bf877-542e-46ed-a13c-bfc8bf133bd1@kernel.dk \
--to=axboe@kernel.dk \
--cc=edumazet@google.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=syzbot+71abe7ab2b70bca770fd@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).