From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: "Matias Bjørling" <mb@lightnvm.io>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lightnvm: pblk: mark expected switch fall-through
Date: Wed, 4 Jul 2018 08:00:56 -0500 [thread overview]
Message-ID: <815c1b76-dad2-a2da-7832-bbaf02ad6be8@embeddedor.com> (raw)
In-Reply-To: <79636e4b-0932-791d-bd06-9f7bbf6d00f3@lightnvm.io>
On 07/04/2018 03:07 AM, Matias Bjørling wrote:
> On 07/03/2018 11:21 PM, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>> ---
>> drivers/lightnvm/pblk-core.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
>> index ed9cc97..9c93334 100644
>> --- a/drivers/lightnvm/pblk-core.c
>> +++ b/drivers/lightnvm/pblk-core.c
>> @@ -264,6 +264,7 @@ void pblk_free_rqd(struct pblk *pblk, struct nvm_rq *rqd, int type)
>> switch (type) {
>> case PBLK_WRITE:
>> kfree(((struct pblk_c_ctx *)nvm_rq_to_pdu(rqd))->lun_bitmap);
>> + /* fall through */
>> case PBLK_WRITE_INT:
>> pool = &pblk->w_rq_pool;
>> break;
>>
>
> Thanks Gustavo. Applied for 4.19.
Thanks, Matias.
--
Gustavo
prev parent reply other threads:[~2018-07-04 13:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 21:21 [PATCH] lightnvm: pblk: mark expected switch fall-through Gustavo A. R. Silva
2018-07-04 8:07 ` Matias Bjørling
2018-07-04 13:00 ` Gustavo A. R. Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=815c1b76-dad2-a2da-7832-bbaf02ad6be8@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mb@lightnvm.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox