From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B804528444 for ; Wed, 14 Oct 2026 13:40:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791985261; cv=none; b=HhwORzJcF9YMPbo8IqOZQo04NCVE87ejNGmZiITIcPsHWlRZAe8MFsPQ4Z15j4LjBkELKdIJ4UCHDCunj0B/cCzZpeEEi8hV/CvcIfkLxXYnuu3is+4ghMxhA8VFyKsmGTMaNxPmSJoIRyrW+KKaRWSLDpf+cb2o9BPjGrTJmNg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791985261; c=relaxed/simple; bh=CWLcIVm0rcAVB8dmp3rQdpqenCY0+xLEuROFe1QppjU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=H8auZbdneTXW+oordqfWg0887CyGzo3nsnfSPty1KD4nP/vsqsFk66mOL6f1RbFs7Gy9NJequz+VQclcp5nTHmQH+Qgu09RyF2l8Cx76UGgZxWPgB+HXcCRmMWMUWhG1pPBu2/LiizgskL5m1oJMfRXyvQ5BRlQWn8aS6rcUjs8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20251104.gappssmtp.com header.i=@kernel-dk.20251104.gappssmtp.com header.b=gPI9alNm; arc=none smtp.client-ip=209.85.210.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20251104.gappssmtp.com header.i=@kernel-dk.20251104.gappssmtp.com header.b="gPI9alNm" Received: by mail-ot1-f48.google.com with SMTP id 46e09a7af769-81ae6aefdceso822231a34.0 for ; Wed, 14 Oct 2026 06:40:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20251104.gappssmtp.com; s=20251104; t=1791985257; x=1792590057; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=TI1InYuhv2BOMB8UNQLzhmzx2APX9vyjkfAbRr4ddfE=; b=gPI9alNmPHQzLVLHa9pr2LsEq59R3xmYYi3aYPUB4nJpK/TlShKZN3qRu7UuBzZ5GN rLp5k7SQj3N+BcoPU4ap/kbLyulaqvsdxSrDQ4J3Y4INe5RJtvCbJV67MdbUhyZ5gGuZ gXN/96s4JTU4NX8tbZ9rmVfbI6LmG7CQJMP5OVgEH2czMNVONaVKQxiCUVya5bTdIRWQ bY8RUn2QsLWoIIdH3MfpRpn0CeWb+xb3XX2dYy4ZvGwKOP7YKQW/H3b9hcNE6yLr3SA8 mh+tT73rjgL4HvWbZioWZNQx3+4RtcmgplYAfZIJ/Wri4sjMpRgXFErsuyDyXUFFs80A 0dWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791985257; x=1792590057; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=TI1InYuhv2BOMB8UNQLzhmzx2APX9vyjkfAbRr4ddfE=; b=vftzCeosd0eyb7svE9p9uSnZBrD7MQB58VOJmmVJEr25hbIVSJV54GWd710sK0MImN yQVz0mIO6+9a/rIT23+0WRVbsDbWL6VAxw0mjMY4iMX5etPdQS1GZjcw3Xk97Nmdppky df6IibtyGqikJiQs0G9LpwByY1WFsG7Tr8LBD499f4yAALELVI9lhPRPbHSazkCt02Pp i0fElsp92F8fW69mxUmnptaXqPxnplAJDjIBa+R+otBoeoz21/iVU98lj/FSbf/NQIwp 6c0gQbhB/4SfOJCXuqoqb+Js4ui9T/Hh56pnYjKS1oDdndy+oVxYC9O1u1Q57/lyI0ay mUPA== X-Forwarded-Encrypted: i=1; AKwUvBxux0IM/G+VntGQ4+FmZAX/levXVDzc8LW+eb5OGwI+axA7wvxIjsAktLF/fZ4S8gd1tNpN6xjCLXoM1Q==@vger.kernel.org X-Gm-Message-State: AFq9FYJAbg2cB0QgRZs09/V7S0mzvNOrSqwORLPn1QcS7h5pEl5VboGj A3fCzRed6hfmpOdosR794Qy9b/fO02vb35rZHQsRK7b9CBm8C8Tole+3st2Xj/kbROAY4WT9iUT Ah4Ov42Y= X-Gm-Gg: AYBFou1swv6QLdb+NhdYRFgjYTpRHjYO/M3UeqB0WQlMaY7bt62JAoEoXsqh9y54ldZ YM22Hvb8uuIZhASWiWHi2FPoeWN3G0d5/Qev5p0SDNikUyS57WU0aEwy5Kn9/L7t+/urtk3qBZs 1pAwsWv0dRSYBN0E/Xn5IsCNUG7paRVR7sgJYGKkU+l0LzE5TXWPrLzQVcXzXA+9KBpIYMQ6qkr 3xjgTUQNoGXqXGdBEBnchdW4dcVgfPa0ZHeU8UyrWYdrxxZBJczgcbtIqF4krbW0VjSw8rxndXp 5g1HrQIV+y1QBogJKbNjx2oCk8za+b+LPAxeD2HksmbfMPkGiiXJVAb1oMkHtqM3Pe3+lLUUlNU 6ogHfuuDrH5uFLzGG0vi9iLUE1U2YSEMLOHINqMbOoptIqiQxdufGJjNiRrux1eQ8o7jIHQqK24 cD2nzX9jB8JTvIyy2W/xA4nChSxQ/mFn91wsI2OYtBc1i5k+a4NkrB3yHc4hZhFqtCCVQ7srCyT Bedrary8nPYcDldgYfqJ8YYk94I82M/NOFkZj4GYg3tMRTJmYGaiNUHIw== X-Received: by 2002:a05:6830:67e4:b0:812:4cc7:4afe with SMTP id 46e09a7af769-830969d183fmr14838309a34.17.1791985256814; Wed, 14 Oct 2026 06:40:56 -0700 (PDT) Received: from [192.168.1.106] ([198.8.77.135]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-83038f822dcsm14657364a34.10.2026.10.14.06.40.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Oct 2026 06:40:56 -0700 (PDT) Message-ID: <81e6538c-977c-4b45-bd44-242ce5e00dd7@kernel.dk> Date: Wed, 14 Oct 2026 07:40:54 -0600 Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11 13/13] io_uring/rsrc: add dmabuf backed registered buffers To: Pavel Begunkov , linux-block@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, Christoph Hellwig , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , Keith Busch , Sagi Grimberg , Alexander Viro , Christian Brauner , Jan Kara , Andrew Morton , Nitesh Shetty , Kanchan Joshi , Anuj Gupta , Tushar Gohad , William Power , Matthew Brost , Alasdair Kergon , Mike Snitzer , Mikulas Patocka , Benjamin Marzinski , dm-devel@lists.linux.dev References: <4aa230df871ee275536f367087b44ebfebb88cc1.1791975048.git.asml.silence@gmail.com> Content-Language: en-US From: Jens Axboe In-Reply-To: <4aa230df871ee275536f367087b44ebfebb88cc1.1791975048.git.asml.silence@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit A few nits: > diff --git a/io_uring/dma-buf.c b/io_uring/dma-buf.c > new file mode 100644 > index 000000000000..1a1a88640823 > --- /dev/null > +++ b/io_uring/dma-buf.c > @@ -0,0 +1,66 @@ > +#include "dma-buf.h" Needs SPDX license header. > diff --git a/io_uring/dma-buf.h b/io_uring/dma-buf.h > new file mode 100644 > index 000000000000..a876a9e5e272 > --- /dev/null > +++ b/io_uring/dma-buf.h > +static inline int io_attach_dmabuf_map(struct io_kiocb *req, > + struct iov_iter *iter, > + unsigned issue_flags) > +{ > + bool nowait = issue_flags & IO_URING_F_NONBLOCK; > + struct dma_buf_io_map *map; > + struct io_buf_dma *bd; > + > + if (!IS_ENABLED(CONFIG_DMA_SHARED_BUFFER)) > + return -EOPNOTSUPP; > + if (!(req->flags & REQ_F_DMABUF)) > + return 0; > + > + bd = req->buf_node->buf->priv; > + map = dma_buf_io_get_map(bd->ctx, nowait); > + if (unlikely(IS_ERR(map))) > + return PTR_ERR(map); No need for unlikely() with IS_ERR(), it already includes that. -- Jens Axboe